text-align: center on base button styles
#772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/7tbmo24n6 |
joelhawksley
added
the
fr-skip
|
Hey @joelhawksley I'm quite new here. What does the |
|
@albingroen it's for our internal tracking. Nothing to worry about! ❤️ |
|
@joelhawksley Awesome, thanks 👍 |
|
Going to merge into a new PR so that I can run the tests (unfortunately our GitHub Actions that do that can only run on branches opened by collaborators) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, buttons that use the
asproperty placed inside of aFlexcontainer will automatically get a left-aligned text. I suppose this is not a expected behaviour. If it is, please let me know 👍My solution is to default the
ButtonStylesto align it's text tocenter(ie.text-align: center)Closes #771
Screenshots
Before
After
Merge checklist