-
Notifications
You must be signed in to change notification settings - Fork 645
Release v19.0.0 #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v19.0.0 #764
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/e7wfif0lt |
|
Might make sense to deprecate StyledOcticon in this release as well, Cole and I would need to create the |
Nope, no urgency, just wanted to have a base branch to set new PRs to :) |
Update Babel transpilation options
|
Since the Octicon changes (most likely) won't be going out in this version, this is now officially ready for review. |
Export from transpiled lib/ instead of src/
Hotfixes: Update SelectMenu.Item type & extend Box in Position
|
Testing sandbox: https://codesandbox.io/s/primer-components-ts-testing-47dbw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one second, need to think about the octicons stuff for a minute!
Expected changes
BorderBoxAPI (breaking change)sxprop + docsRemoval of StyledOcticon in favor of @primer/styled-octiconsStateLabelSelectMenu.ModalReferences:
Closes #797
Closes #456
Closes #797
Closes #801
Closes #510
Closes #752
Release notes
🚨 Breaking Changes
Removed "Segoe UI Symbol" from font stack as it is not compatible with Chinese characters Remove "Segoe UI Symbol" from font stack #769 @skw
BorderBoxhas had its defaultborderprop split intoborderWidthandborderStyle:before:
after:
While this change was made to fix bugs in the ability to modify
BorderBox's border, it is also a breaking change if you useborderorborder<Direction>shorthand props to modify the border, as these will no longer work. Instead, use non-shorthand props. For example, changeto
BorderBox and related (breaking) changes #761 @BinaryMuse
Flexnow behaves exactly likeBoxexcept that it has itsdisplayprop set toflexby default BorderBox and related (breaking) changes #761 @BinaryMuseFlex.Item, previously deprecated, has been removed in favor ofBox, which now has all the same props BorderBox and related (breaking) changes #761 @BinaryMusetheme.bordershas been removed; use the newborderWidthstheme values forborderWidthproperties (0is a width of0,1is a width of1px) BorderBox and related (breaking) changes #761 @BinaryMuse🚫 Deprecations
Starting this version, we will be adding a deprecation period for breaking API changes whenever possible. When using a deprecated feature, you will see a warning in the JavaScript console that details how you should change your usage as well as the version at which we plan to remove the deprecated feature.
The
Flashcomponent'sschemeprop has been deprecated in favor of a newvariantprop. We plan to remove theschemeprop in version 20.To migrate:
Change▶️ ▶️ ▶️ ▶️
scheme='blue'tovariant='default'Change
scheme='green'tovariant='success'Change
scheme='red'tovariant='danger'Change
scheme='yellow'tovariant='warning'Flash refresh + Refactor #777 @emplums
StateLabel'ssmallprop is deprecated in favor of a newvariantprop. Usevariant="small"to achieve the same result. We plan to remove thesmallprop in version 20. StateLabel modernization #798 Switch to usage of variant for StateLabel and remove theme calls #752 @tiaanduplessis @BinaryMuse💅 Enhancements
Box(and components that inherit from it, likeBorderBox) now have access toFLEXsystem props BorderBox and related (breaking) changes #761 @BinaryMusePositionand its family members (Relative,Absolute,Sticky, andFixed) now inherit fromBoxand receiveFLEXsystem props.A new prop,
sx, has been added to all components to allow theme-aware ad-hoc styles. See the prop's documentation for more information. Addsxprop for theme-aware ad-hoc styles #755 @BinaryMuseEach component can now be imported individually, without importing all of Primer Components. For example,
import Box from '@primer/components/lib/Box'. Users using an ESM-compatible module bundler should not use this import style. See the usage docs for more information. Create actual browser bundles and transpile everything else #789 @BinaryMuseThe following colors have been added:
BorderBox and related (breaking) changes #761 @BinaryMuse
Allow
SelectMenu.Itemto beaorbuttonAllow SelectMenu.Item to beaorbutton#787SelectMenu.Modalhas a new propertyalign; setalign='right'to right-align the modal @dmarcey Add align='right' prop to SelectMenu.Modal #800🐛 Bug Fixes
text-alignto buttonstext-align: centeron base button styles #772 @albingroen