Skip to content

Conversation

@BinaryMuse
Copy link
Contributor

@BinaryMuse BinaryMuse commented Apr 16, 2020

Expected changes

References:

Closes #797
Closes #456
Closes #797
Closes #801
Closes #510
Closes #752

Release notes

🚨 Breaking Changes

  • Removed "Segoe UI Symbol" from font stack as it is not compatible with Chinese characters Remove "Segoe UI Symbol" from font stack #769 @skw

  • BorderBox has had its default border prop split into borderWidth and borderStyle:

    before:

    BorderBox.defaultProps = {
      border: '1px solid',
      borderColor: 'gray.2',
      borderRadius: 2
    }

    after:

    BorderBox.defaultProps = {
      borderWidth: '1px',
      borderStyle: 'solid',
      borderColor: 'gray.2',
      borderRadius: 2
    }

    While this change was made to fix bugs in the ability to modify BorderBox's border, it is also a breaking change if you use border or border<Direction> shorthand props to modify the border, as these will no longer work. Instead, use non-shorthand props. For example, change

    <BorderBox border={0} borderTop={1}>...</BorderBox>

    to

    <BorderBox borderWidth={0} borderTopWidth={1}>...</BorderBox>

    BorderBox and related (breaking) changes #761 @BinaryMuse

  • Flex now behaves exactly like Box except that it has its display prop set to flex by default BorderBox and related (breaking) changes #761 @BinaryMuse

  • Flex.Item, previously deprecated, has been removed in favor of Box, which now has all the same props BorderBox and related (breaking) changes #761 @BinaryMuse

  • theme.borders has been removed; use the new borderWidths theme values for borderWidth properties (0 is a width of 0, 1 is a width of 1px) BorderBox and related (breaking) changes #761 @BinaryMuse

🚫 Deprecations

Starting this version, we will be adding a deprecation period for breaking API changes whenever possible. When using a deprecated feature, you will see a warning in the JavaScript console that details how you should change your usage as well as the version at which we plan to remove the deprecated feature.

💅 Enhancements

🐛 Bug Fixes

@BinaryMuse BinaryMuse added the major release breaking changes label Apr 16, 2020
@vercel
Copy link

vercel bot commented Apr 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/e7wfif0lt
✅ Preview: https://primer-components-git-release-1900.primer.now.sh

@emplums
Copy link

emplums commented Apr 17, 2020

Might make sense to deprecate StyledOcticon in this release as well, Cole and I would need to create the @primer/styled-octicons package first though, not sure if this release has any urgency, if so we could do it in a different major version

@BinaryMuse
Copy link
Contributor Author

not sure if this release has any urgency

Nope, no urgency, just wanted to have a base branch to set new PRs to :)

@vercel vercel bot temporarily deployed to Preview May 7, 2020 18:31 Inactive
@vercel vercel bot temporarily deployed to Preview May 7, 2020 21:07 Inactive
@BinaryMuse
Copy link
Contributor Author

BinaryMuse commented May 7, 2020

Since the Octicon changes (most likely) won't be going out in this version, this is now officially ready for review.

@BinaryMuse BinaryMuse marked this pull request as ready for review May 7, 2020 21:07
@vercel vercel bot temporarily deployed to Preview May 7, 2020 21:20 Inactive
@vercel vercel bot temporarily deployed to Preview May 7, 2020 23:30 Inactive
Emily Plummer and others added 3 commits May 7, 2020 16:40
@vercel vercel bot temporarily deployed to Preview May 8, 2020 17:14 Inactive
Emily Plummer added 2 commits May 8, 2020 10:28
Hotfixes: Update SelectMenu.Item type & extend Box in Position
@vercel vercel bot temporarily deployed to Preview May 8, 2020 17:31 Inactive
@emplums
Copy link

emplums commented May 8, 2020

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one second, need to think about the octicons stuff for a minute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major release breaking changes

Projects

None yet

9 participants