Flash refresh + Refactor

[emplums]

This PR updates the Flash component with the new refresh styles ✨

I've also taken this opportunity to refactor a bit. We were previously using the scheme prop when we really should have been using variant. Sadly, this creates a breaking change but I believe it's worth it to get close to consistency. We were also naming our "schemes" based on colors, when really they should be named to describe the type of Flash (success, warning, danger, default) to aid the user in knowing which variant to use for which purpose.

These new updates also include default styling for icons included in Flash alerts - just like in Primer CSS, we set the color of any icon included in a flash alert to match the variant styling.

Screenshots

Before:

After:

( I removed the margin between the components to make the code more copy-able, but i'm not 100% attached to this change)

Merge checklist

• Added or updated TypeScript definitions (index.d.ts) if necessary
• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/i48ku2tlj
✅ Preview: https://primer-components-git-flash-refresh.primer.now.sh

[auareyou]

Values look good! 👍

[BinaryMuse]

Looks good. Do you mind adding a migration strategy to the release notes?

[colebemis]

Is the border-radius of the flash container supposed to be bigger now? It looks the same in the before and after screenshots.

[emplums]

Nice catch @colebemis 🤦‍♀️ 😂

Done @BinaryMuse !

[BinaryMuse]

@emplums 🤔🤔🤔 worth using the new deprecation stuff for? (keep scheme for now but log a warning and support variant)

[emplums]

@BinaryMuse yeah good idea! i'll add the deprecation stuff to this PR.

[emplums]

Note: @BinaryMuse is going to add a conditional to deprecate in a follow up PR to only show the console.warn in development modes

[emplums]

@BinaryMuse I think the yarn.lock file in the 19.0.0 branch might be corrupted or something, because I have no changes to package.json in this branch and after merging in the release branch running yarn generates a ton of yarn.lock changes 🤔

[BinaryMuse]

@BinaryMuse I think the yarn.lock file in the 19.0.0 branch might be corrupted or something, because I have no changes to package.json in this branch and after merging in the release branch running yarn generates a ton of yarn.lock changes 🤔

Hm, I pulled the release branch and ran yarn but got no changes. Can you share the diff you're getting?