Skip to content

Fix typo 'Dropdown.Caret.propTpyes' to 'Dropdown.Caret.propTypes' #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix typo 'Dropdown.Caret.propTpyes' to 'Dropdown.Caret.propTypes' #783

merged 1 commit into from
Apr 29, 2020

Conversation

@andrewhillcode
Copy link
Contributor

@andrewhillcode andrewhillcode commented Apr 28, 2020

I noticed that this line was typo'd

Merge checklist

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@vercel
Copy link

vercel bot commented Apr 28, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/8u9vv7zky
✅ Preview: https://primer-component-git-fork-andrewhillcode-andrewhillcode-9bccbc.primer.now.sh

@vercel vercel bot temporarily deployed to Preview April 28, 2020 12:56 Inactive
@andrewhillcode andrewhillcode changed the title Fix typo 'Dropdown.Caret.propTpyes' to 'propTypes' Fix typo 'Dropdown.Caret.propTpyes' to 'Dropdown.Caret.propTypes' Apr 28, 2020
@auareyou auareyou added the fr-skip Remove this from the Design Systems first responder list label Apr 28, 2020
@emplums emplums changed the base branch from master to release-19.0.0 April 29, 2020 16:28
emplums
emplums approved these changes Apr 29, 2020
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! 🙌 thanks for the PR!

@emplums emplums merged commit 1dad9ac into primer:release-19.0.0 Apr 29, 2020
@BinaryMuse BinaryMuse mentioned this pull request Apr 29, 2020
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emplums emplums emplums approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fr-skip Remove this from the Design Systems first responder list

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewhillcode @emplums @auareyou