Timeline: tag Dependabot event stories with taxonomy data-* attributes#8219
Closed
janmaarten-a11y wants to merge 1 commit into
Closed
Timeline: tag Dependabot event stories with taxonomy data-* attributes#8219janmaarten-a11y wants to merge 1 commit into
janmaarten-a11y wants to merge 1 commit into
Conversation
Spread the event data-* contract onto each cataloged Timeline.Item in the Dependabot feature stories, projected from the merged taxonomy module via a local dependabotAttrs helper. Derive category and visibility from DEPENDABOT_TAXONOMY and resolve data-actor-type at runtime from each row's rendered actor login. Leave the shared Assignment and Copilot-work events untagged, matching the per-surface catalog.
|
primer
Bot
deleted the
janmaarten-a11y-timeline-dependabot-taxonomy-tagging
branch
July 23, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tags the Dependabot Timeline event stories with the taxonomy
data-*attributes, part of the Phase 3 tagging fan-out (github/primer#6664, epic github/primer#6654). It applies the samedata-*contract proven by the License Compliance pilot (#8216), consuming the merged taxonomy module (#8180) and its docs (github/primer#6888).Each cataloged
Timeline.IteminTimeline.dependabot.features.stories.tsxspreads the output of a localdependabotAttrshelper, which projectstoEventDataAttributes. The helper derivesdata-event-categoryanddata-event-visibilityfrom theDEPENDABOT_TAXONOMYcatalog entry (never hand-typed) and resolvesdata-actor-typeat runtime from each row's rendered actor login: Dependabot authored rows resolve tobot, user driven rows touser.Per rendered
<li>the contract is:data-event-scope="dependabot",data-event-type(the unscoped leaf),data-event-category,data-event-visibility(defaultsprimary), anddata-actor-type. The event groups map as: Opened rows toopened, Fixed rows tofixed, all Dismissed and Auto-dismissed rows todismissed, all Reopened, Reintroduced and Auto-reopened rows toreopened, and the delegated dismissal rows todismissal_requested,dismissal_reviewed(approved and denied), anddismissal_cancelled.The Assignment and Copilot-work event groups stay untagged. They are cross-surface shared events deliberately kept out of the per-surface Dependabot catalog (github/primer#6888), so they intentionally carry no
data-*attributes. A code comment above each group records this.This is a Storybook-only change with no visual difference and no runtime component change.
Changelog
New
data-*attributes on the cataloged Dependabot Timeline event storyrows.
Changed
Removed
Rollout strategy
Storybook-only story changes with no published-package impact, so no release is needed. The PR carries the
skip changesetlabel.Testing & Reviewing
Validated against the repository's own gates with zero new errors: prettier, eslint, stylelint, and type-check. A temporary browser test rendered the tagged stories in real Chromium and asserted the rendered
<li>rows:EventOpenedrow carriesdata-event-scope="dependabot",data-event-type="opened",data-event-category="findings",data-event-visibility="primary",data-actor-type="bot".EventDismissedrow carriesdata-actor-type="user"; an auto-dismissed row carriesdata-actor-type="bot".EventDismissalRequestcancelled row carriesdata-event-type="dismissal_cancelled"anddata-event-category="reviews".EventAssignmentandEventCopilotWorkrows carry nodata-event-*attributes.The temporary test was removed after validation. Reviewers can confirm the attributes in Storybook via the browser inspector on any Dependabot event story.