Skip to content

Timeline: tag Dependabot event stories with taxonomy data-* attributes#8219

Closed
janmaarten-a11y wants to merge 1 commit into
mainfrom
janmaarten-a11y-timeline-dependabot-taxonomy-tagging
Closed

Timeline: tag Dependabot event stories with taxonomy data-* attributes#8219
janmaarten-a11y wants to merge 1 commit into
mainfrom
janmaarten-a11y-timeline-dependabot-taxonomy-tagging

Conversation

@janmaarten-a11y

@janmaarten-a11y janmaarten-a11y commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This tags the Dependabot Timeline event stories with the taxonomy data-* attributes, part of the Phase 3 tagging fan-out (github/primer#6664, epic github/primer#6654). It applies the same data-* contract proven by the License Compliance pilot (#8216), consuming the merged taxonomy module (#8180) and its docs (github/primer#6888).

Each cataloged Timeline.Item in Timeline.dependabot.features.stories.tsx spreads the output of a local dependabotAttrs helper, which projects toEventDataAttributes. The helper derives data-event-category and data-event-visibility from the DEPENDABOT_TAXONOMY catalog entry (never hand-typed) and resolves data-actor-type at runtime from each row's rendered actor login: Dependabot authored rows resolve to bot, user driven rows to user.

Per rendered <li> the contract is: data-event-scope="dependabot", data-event-type (the unscoped leaf), data-event-category, data-event-visibility (defaults primary), and data-actor-type. The event groups map as: Opened rows to opened, Fixed rows to fixed, all Dismissed and Auto-dismissed rows to dismissed, all Reopened, Reintroduced and Auto-reopened rows to reopened, and the delegated dismissal rows to dismissal_requested, dismissal_reviewed (approved and denied), and dismissal_cancelled.

The Assignment and Copilot-work event groups stay untagged. They are cross-surface shared events deliberately kept out of the per-surface Dependabot catalog (github/primer#6888), so they intentionally carry no data-* attributes. A code comment above each group records this.

This is a Storybook-only change with no visual difference and no runtime component change.

Changelog

New

  • Taxonomy data-* attributes on the cataloged Dependabot Timeline event story
    rows.

Changed

  • Nothing consumer-facing. Story markup only.

Removed

  • Nothing.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Storybook-only story changes with no published-package impact, so no release is needed. The PR carries the skip changeset label.

Testing & Reviewing

Validated against the repository's own gates with zero new errors: prettier, eslint, stylelint, and type-check. A temporary browser test rendered the tagged stories in real Chromium and asserted the rendered <li> rows:

  • An EventOpened row carries data-event-scope="dependabot", data-event-type="opened", data-event-category="findings", data-event-visibility="primary", data-actor-type="bot".
  • A manual EventDismissed row carries data-actor-type="user"; an auto-dismissed row carries data-actor-type="bot".
  • The EventDismissalRequest cancelled row carries data-event-type="dismissal_cancelled" and data-event-category="reviews".
  • EventAssignment and EventCopilotWork rows carry no data-event-* attributes.

The temporary test was removed after validation. Reviewers can confirm the attributes in Storybook via the browser inspector on any Dependabot event story.

Spread the event data-* contract onto each cataloged Timeline.Item in the
Dependabot feature stories, projected from the merged taxonomy module via a
local dependabotAttrs helper. Derive category and visibility from
DEPENDABOT_TAXONOMY and resolve data-actor-type at runtime from each row's
rendered actor login. Leave the shared Assignment and Copilot-work events
untagged, matching the per-surface catalog.
@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6097825

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@janmaarten-a11y janmaarten-a11y added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test component: Timeline labels Jul 22, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8219 July 22, 2026 20:31 Inactive
@primer
primer Bot deleted the janmaarten-a11y-timeline-dependabot-taxonomy-tagging branch July 23, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Timeline integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant