Conversation
🦋 Changeset detectedLatest commit: 14df563 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
reviewed
Aug 3, 2022
langermank
reviewed
Sep 24, 2022
jonrohan
reviewed
Sep 26, 2022
jonrohan
reviewed
Sep 26, 2022
…move sub item logic to nav list item
langermank
reviewed
Sep 26, 2022
jonrohan
approved these changes
Sep 27, 2022
Member
jonrohan
left a comment
jonrohan
left a comment
There was a problem hiding this comment.
Seems good 👍🏻
Had one non-blocking question. Should we add to the Deprecations class for migrating from the old Navigation element in dotcom to this?
Collaborator
Author
|
Hey @jonrohan, yes! I have a dotcom branch that does just that for the old |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
ActionListandNavListcomponents. Interface guidelines forActionListcan be found here.NavListreplaces the existing experimentalNavigationListcomponent inside dotcom, and usesActionListas its base.ActionListis intended to be used only as a base class and should not be used directly by consumers.Please see the Lookbook examples and documentation pages for more details.