Move Primer::SpinnerComponent to Primer::Beta::Spinner#1698
Merged
mxriverlynn merged 8 commits intomainfrom Dec 9, 2022
Merged
Move Primer::SpinnerComponent to Primer::Beta::Spinner#1698mxriverlynn merged 8 commits intomainfrom
Primer::SpinnerComponent to Primer::Beta::Spinner#1698mxriverlynn merged 8 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 3a5e3ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
54 tasks
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
|
mxriverlynn
force-pushed
the
mxriverlynn/move-spinner
branch
from
8f16e20 to
4729867
Compare
mxriverlynn
temporarily deployed
to
review-pr-1698
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
jonrohan
approved these changes
Dec 9, 2022
jonrohan
reviewed
Dec 9, 2022
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
Primer::SpinnerComponenttoPrimer::Beta::Spinner, and deprecate the originalIntegration
no immediate change, but deprecations need to be cleaned up
Merge checklist