Update to Rails 7.2#3625
Conversation
|
…nd app config Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Updated actionpack, actionview, activemodel, activesupport, and railties to version 8.0.2 in Gemfile.lock.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum supported Rails version from 7.1 to 7.2.2.1 across the repository, ensuring the gem stays current with supported Rails versions while maintaining forward compatibility.
- Updates gem dependencies to require Rails 7.2.0+
- Updates CI testing matrix to test against Rails 7.2.2.1
- Adds Rails 7.2 configuration support in demo application
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| primer_view_components.gemspec | Updates minimum Rails dependency from 7.1.0 to 7.2.0 |
| demo/config/application.rb | Adds Rails 7.2 configuration defaults loading |
| demo/Gemfile | Updates default Rails version from 7.1.3.2 to 7.2.2.1 |
| .github/workflows/test.yml | Updates CI matrix to test against Rails 7.2.2.1 instead of 7.1.3 |
This PR updates the minimum supported Rails version from 7.1 to 7.2.2.1 across the repository.
Closes https://github.com/github/primer/issues/5599
Closes https://github.com/github/primer/issues/5569
Changes Made
CI Testing Matrix
.github/workflows/test.ymlto test against Rails 7.2.2.1 instead of 7.1.3mainbranch for forward compatibilityDemo Application
demo/Gemfiledefault Rails version from 7.1.3.2 to 7.2.2.1demo/config/application.rbto properly load defaults for Rails 7.2Gem Dependencies
primer_view_components.gemspecto requireactionview >= 7.2.0andactivesupport >= 7.2.0Testing
Basic lib tests pass successfully with Rails 7.2.2.1, confirming compatibility:
The update follows Rails' deprecation timeline and ensures the gem stays current with supported Rails versions while maintaining compatibility with the latest Rails releases.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=5313 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6141900249810457987,723012800735187356,262144 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=IsolateOrigins,PaintHolding,TranslateUI,site-per-process --variations-seed-version(dns block)/opt/google/chrome/chrome --headless --disable-gpu --hide-scrollbars --mute-audio --enable-automation --disable-web-security --disable-session-crashed-bubble --disable-breakpad --disable-sync --no-first-run --use-mock-keychain --keep-alive-for-test --disable-popup-blocking --disable-extensions --disable-component-extensions-with-REDACTED-pages --disable-hang-monitor --disable-features=site-per-process,IsolateOrigins,TranslateUI --disable-translate --disable-REDACTED-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-site-isolation-trials --force-color-profile=srgb --metrics-recording-only --safebrowsing-disable-auto-update --password-store=basic --no-startup-window --remote-debugging-port=0 --remote-debugging-address=127.0.0.1 --window-size=1024,768 --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl(dns block)clients2.google.com/opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=5313 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6141900249810457987,723012800735187356,262144 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=IsolateOrigins,PaintHolding,TranslateUI,site-per-process --variations-seed-version(dns block)/opt/google/chrome/chrome --headless --disable-gpu --hide-scrollbars --mute-audio --enable-automation --disable-web-security --disable-session-crashed-bubble --disable-breakpad --disable-sync --no-first-run --use-mock-keychain --keep-alive-for-test --disable-popup-blocking --disable-extensions --disable-component-extensions-with-REDACTED-pages --disable-hang-monitor --disable-features=site-per-process,IsolateOrigins,TranslateUI --disable-translate --disable-REDACTED-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-site-isolation-trials --force-color-profile=srgb --metrics-recording-only --safebrowsing-disable-auto-update --password-store=basic --no-startup-window --remote-debugging-port=0 --remote-debugging-address=127.0.0.1 --window-size=1024,768 --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl(dns block)safebrowsingohttpgateway.googleapis.com/opt/google/chrome/chrome --headless --disable-gpu --hide-scrollbars --mute-audio --enable-automation --disable-web-security --disable-session-crashed-bubble --disable-breakpad --disable-sync --no-first-run --use-mock-keychain --keep-alive-for-test --disable-popup-blocking --disable-extensions --disable-component-extensions-with-REDACTED-pages --disable-hang-monitor --disable-features=site-per-process,IsolateOrigins,TranslateUI --disable-translate --disable-REDACTED-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-site-isolation-trials --force-color-profile=srgb --metrics-recording-only --safebrowsing-disable-auto-update --password-store=basic --no-startup-window --remote-debugging-port=0 --remote-debugging-address=127.0.0.1 --window-size=1024,768 --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl(dns block)/opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=5313 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6141900249810457987,723012800735187356,262144 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=IsolateOrigins,PaintHolding,TranslateUI,site-per-process --variations-seed-version(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.