Skip to content

Update to Rails 7.2#3625

Merged
jonrohan merged 4 commits into
mainfrom
copilot/fix-91c91bd5-70ec-45cd-b930-2a6a713655a1
Aug 4, 2025
Merged

Update to Rails 7.2#3625
jonrohan merged 4 commits into
mainfrom
copilot/fix-91c91bd5-70ec-45cd-b930-2a6a713655a1

Conversation

Copilot AI commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

This PR updates the minimum supported Rails version from 7.1 to 7.2.2.1 across the repository.

Closes https://github.com/github/primer/issues/5599
Closes https://github.com/github/primer/issues/5569

Changes Made

CI Testing Matrix

  • Updated .github/workflows/test.yml to test against Rails 7.2.2.1 instead of 7.1.3
  • Maintains testing against Rails main branch for forward compatibility

Demo Application

  • Updated demo/Gemfile default Rails version from 7.1.3.2 to 7.2.2.1
  • Added Rails 7.2 configuration support in demo/config/application.rb to properly load defaults for Rails 7.2

Gem Dependencies

  • Updated primer_view_components.gemspec to require actionview >= 7.2.0 and activesupport >= 7.2.0
  • This ensures compatibility with Rails 7.2+ while maintaining forward compatibility with Rails 8.x

Testing

Basic lib tests pass successfully with Rails 7.2.2.1, confirming compatibility:

  • ✅ Core functionality works with Rails 7.2.2.1
  • ✅ Application configuration correctly loads Rails 7.2 defaults
  • ✅ Backward compatibility maintained with newer Rails versions

The update follows Rails' deprecation timeline and ensures the gem stays current with supported Rails versions while maintaining compatibility with the latest Rails releases.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=5313 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6141900249810457987,723012800735187356,262144 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=IsolateOrigins,PaintHolding,TranslateUI,site-per-process --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --headless --disable-gpu --hide-scrollbars --mute-audio --enable-automation --disable-web-security --disable-session-crashed-bubble --disable-breakpad --disable-sync --no-first-run --use-mock-keychain --keep-alive-for-test --disable-popup-blocking --disable-extensions --disable-component-extensions-with-REDACTED-pages --disable-hang-monitor --disable-features=site-per-process,IsolateOrigins,TranslateUI --disable-translate --disable-REDACTED-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-site-isolation-trials --force-color-profile=srgb --metrics-recording-only --safebrowsing-disable-auto-update --password-store=basic --no-startup-window --remote-debugging-port=0 --remote-debugging-address=127.0.0.1 --window-size=1024,768 --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl (dns block)
  • clients2.google.com
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=5313 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6141900249810457987,723012800735187356,262144 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=IsolateOrigins,PaintHolding,TranslateUI,site-per-process --variations-seed-version (dns block)
    • Triggering command: /opt/google/chrome/chrome --headless --disable-gpu --hide-scrollbars --mute-audio --enable-automation --disable-web-security --disable-session-crashed-bubble --disable-breakpad --disable-sync --no-first-run --use-mock-keychain --keep-alive-for-test --disable-popup-blocking --disable-extensions --disable-component-extensions-with-REDACTED-pages --disable-hang-monitor --disable-features=site-per-process,IsolateOrigins,TranslateUI --disable-translate --disable-REDACTED-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-site-isolation-trials --force-color-profile=srgb --metrics-recording-only --safebrowsing-disable-auto-update --password-store=basic --no-startup-window --remote-debugging-port=0 --remote-debugging-address=127.0.0.1 --window-size=1024,768 --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /opt/google/chrome/chrome --headless --disable-gpu --hide-scrollbars --mute-audio --enable-automation --disable-web-security --disable-session-crashed-bubble --disable-breakpad --disable-sync --no-first-run --use-mock-keychain --keep-alive-for-test --disable-popup-blocking --disable-extensions --disable-component-extensions-with-REDACTED-pages --disable-hang-monitor --disable-features=site-per-process,IsolateOrigins,TranslateUI --disable-translate --disable-REDACTED-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-client-side-phishing-detection --disable-default-apps --disable-dev-shm-usage --disable-ipc-flooding-protection --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-site-isolation-trials --force-color-profile=srgb --metrics-recording-only --safebrowsing-disable-auto-update --password-store=basic --no-startup-window --remote-debugging-port=0 --remote-debugging-address=127.0.0.1 --window-size=1024,768 --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --noerrdialogs --ozone-platform=headless --ozone-override-screen-size=800,600 --use-angle=swiftshader-webgl (dns block)
    • Triggering command: /opt/google/chrome/chrome --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --crashpad-handler-pid=5313 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/ferrum_user_data_dir_20250805-5285-kxixvm --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6141900249810457987,723012800735187356,262144 --enable-features=NetworkService,NetworkServiceInProcess --disable-features=IsolateOrigins,PaintHolding,TranslateUI,site-per-process --variations-seed-version (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot

changeset-bot Bot commented Aug 4, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f7bedee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…nd app config

Co-authored-by: jonrohan <54012+jonrohan@users.noreply.github.com>
Copilot AI changed the title [WIP] Can you update to Rails 7.2 Update to Rails 7.2 Aug 4, 2025
Copilot AI requested a review from jonrohan August 4, 2025 17:23
Comment thread Gemfile.lock Outdated
Updated actionpack, actionview, activemodel, activesupport, and railties to version 8.0.2 in Gemfile.lock.
@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label Aug 4, 2025
@jonrohan jonrohan marked this pull request as ready for review August 4, 2025 18:03
Copilot AI review requested due to automatic review settings August 4, 2025 18:03
@jonrohan jonrohan requested a review from a team as a code owner August 4, 2025 18:03
@jonrohan jonrohan requested a review from pksjce August 4, 2025 18:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum supported Rails version from 7.1 to 7.2.2.1 across the repository, ensuring the gem stays current with supported Rails versions while maintaining forward compatibility.

  • Updates gem dependencies to require Rails 7.2.0+
  • Updates CI testing matrix to test against Rails 7.2.2.1
  • Adds Rails 7.2 configuration support in demo application

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
primer_view_components.gemspec Updates minimum Rails dependency from 7.1.0 to 7.2.0
demo/config/application.rb Adds Rails 7.2 configuration defaults loading
demo/Gemfile Updates default Rails version from 7.1.3.2 to 7.2.2.1
.github/workflows/test.yml Updates CI matrix to test against Rails 7.2.2.1 instead of 7.1.3

@jonrohan jonrohan merged commit 5c29d4a into main Aug 4, 2025
31 of 32 checks passed
@jonrohan jonrohan deleted the copilot/fix-91c91bd5-70ec-45cd-b930-2a6a713655a1 branch August 4, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Pull requests that don't change the library output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants