Skip to content

Conversation

@shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Jul 31, 2024

Describe your changes

  • Removes prev functionality requiring the protocol fee recipient to submit a tx to receive funds
  • Removes ability to not specify a protocol fee recipient
  • Adds automatic fee payout functionality that pays accumulated protocol fees to the appropriate address after a configurable amount of blocks
  • Misc documentation/naming refactors

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have tested this code by deploying the infrastructure and ensuring that commitments are being settled

@shaspitz shaspitz requested review from Mikelle and ckartik July 31, 2024 02:06
@ckartik
Copy link
Contributor

ckartik commented Jul 31, 2024

What's going to trigger the fee payouts here?

@shaspitz
Copy link
Contributor Author

What's going to trigger the fee payouts here?

Oracle invoked transactions

Copy link
Contributor

@Mikelle Mikelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the oracle didn’t perform any slashes or rewards, but we still want to withdraw protocol revenue? Do we want to have a mechanism to withdraw those funds without relying on the slashing/rewarding mechanism?

@shaspitz
Copy link
Contributor Author

What if the oracle didn’t perform any slashes or rewards, but we still want to withdraw protocol revenue? Do we want to have a mechanism to withdraw those funds without relying on the slashing/rewarding mechanism?

This edge case most likely won't happen as after 1 hour, it would take a single slash/reward invocation to trigger the fee payout. But it wouldn't hurt to cover the edge case anyways 👍, see 9bc6976

@shaspitz shaspitz merged commit 11e33f9 into main Jul 31, 2024
@shaspitz shaspitz deleted the fee-payout branch July 31, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants