-
Notifications
You must be signed in to change notification settings - Fork 20
feat: automatic protocol fee payout #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What's going to trigger the fee payouts here? |
Oracle invoked transactions |
Mikelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the oracle didn’t perform any slashes or rewards, but we still want to withdraw protocol revenue? Do we want to have a mechanism to withdraw those funds without relying on the slashing/rewarding mechanism?
This edge case most likely won't happen as after 1 hour, it would take a single slash/reward invocation to trigger the fee payout. But it wouldn't hurt to cover the edge case anyways 👍, see 9bc6976 |
Describe your changes
Checklist before requesting a review