Skip to content

Conversation

@ckartik
Copy link
Contributor

@ckartik ckartik commented Jul 31, 2024

Describe your changes

  • Previously, we were setting the Fee allocated to the treasury due to slashing events to zero, before pulling the funds. We update this to ensure we keep a temporary variable that stores the value meant for the treasury during retrieval. We also set the slashing percentage reward for the protocol to 5%.

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have tested this code by deploying the infrastructure and ensuring that commitments are being settled

@ckartik ckartik marked this pull request as ready for review July 31, 2024 16:22
@ckartik ckartik force-pushed the ckartik/hotfix-pull-all-funds-fee-recipient branch from fef004b to aeae44f Compare July 31, 2024 16:39
0x68bC10674b265f266b4b1F079Fa06eF4045c3ab9
);
uint16 feePercent = 2;
uint16 slashPercent = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above change will be n/a with #293, but we can use this change

@ckartik
Copy link
Contributor Author

ckartik commented Aug 7, 2024

Duplicate given shawns other changes.

@ckartik ckartik closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants