Parity fixtures: assert output on 48 request-only generated-alias cases - #335
Merged
Conversation
48 "generated ... alias request" fixtures asserted only the emitted HTTP
request: no stdout, stderr, or exit-code expectation, and Node<->Rust
cross-comparison off. Response rendering for those commands was entirely
unverified on both CLIs.
Each case's mock already returns {success: true, data: null}, so all 48
now assert stdout "null\n", empty stderr, implicit exit 0, and run with
full cross-compare. All pass unchanged, confirming the two CLIs render
these paths identically; the assertions keep it that way.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| test-fixtures/cli-parity/cases.json | Adds stdout and stderr expectations to generated-alias CLI parity cases and re-enables cross-runner comparison. |
Reviews (2): Last reviewed commit: "Merge updated rust-cli-port base" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
etbyrd
force-pushed
the
rust-cli-port
branch
2 times, most recently
from
July 21, 2026 17:25
322c5b5 to
0765fa5
Compare
# Conflicts: # .github/workflows/rust-cli-release.yml # .github/workflows/sdk-checks.yml # Makefile # cli-rust/src/completion_commands.rs # cli-rust/src/friendly.rs # cli-rust/src/functions_commands.rs # cli-rust/src/help_snapshots.generated.rs # cli-rust/src/payments.rs # cli-rust/tests/completion_commands.rs # scripts/generate-rust-cli-help-snapshots.mjs # scripts/run-cli-help-sweep.mjs # scripts/run-cli-parity.mjs # test-fixtures/cli-parity/cases.json
poiley
added a commit
that referenced
this pull request
Jul 22, 2026
…339) PR #335 removed compare:false and added stdout/stderr assertions to the 48 request-only "generated ... alias request" fixtures, but the conflict resolution when landing #332 reverted them via an ours-wins union. Re-apply the transformation: assert stdout "null\n" + empty stderr + full Node<->Rust cross-compare on each (the mocks already return {success:true,data:null}). make cli-parity: 485 cases green. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parity backlog: 48 "generated … alias request" fixtures asserted only the emitted HTTP request, with
compare: falseand no stdout/stderr/exit expectations, so response rendering for those command paths was unverified on both CLIs.What changed
Fixture-only. Each case's mock already returns
{success: true, data: null}; all 48 now additionally assertstdout: "null\n", empty stderr, implicit exit 0, and dropcompare: falseso Node↔Rust cross-comparison runs.All 48 pass without any code change, which is itself the useful result: the two CLIs already render these paths identically, and the corpus now enforces it instead of assuming it.
Validation
make cli-parity: 457/457 green.🤖 Generated with Claude Code