fix(xai): cast empty tool properties to object in xAI ToolMap#977
Open
Cbrad24 wants to merge 1 commit into
Open
fix(xai): cast empty tool properties to object in xAI ToolMap#977Cbrad24 wants to merge 1 commit into
Cbrad24 wants to merge 1 commit into
Conversation
Cbrad24
changed the title
wishborn
added a commit
to Particle-Academy/prism
that referenced
this pull request
Jul 6, 2026
wishborn
added a commit
to Particle-Academy/prism
that referenced
this pull request
Jul 6, 2026
Corrects prism-php#977 (xAI) to the established convention used by the Anthropic and OpenRouter maps ($properties === [] ? new \stdClass : $properties) so non-empty parameters stay arrays, and applies the same fix to Groq and Z, which had the identical latent bug (empty properties serialized as [] instead of {}). DeepSeek and OpenAI already omit the parameters block when a tool has none. Adds regression tests for all three maps. Refs prism-php#1007. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a tool has no parameters/inputs, the xAI provider sends
"properties": [](JSON array)instead of
"properties": {}(JSON object)in the tool definition.
xAI's API rejects this with a 400 error.
This is the same class of PHP empty-array serialization issue fixed in #896 for
MessageMap, but inToolMap(tool definitions rather than tool call arguments).Before
{ "type": "function", "function": { "name": "list_users", "description": "List all users", "parameters": { "type": "object", "properties": [], // Causes 400 error "required": [] } } }After
{ "type": "function", "function": { "name": "list_users", "description": "List all users", "parameters": { "type": "object", "properties": {}, // Works "required": [] } } }Fix
Cast
$tool->parametersAsArray()to(object)so empty arrays serialize as{}.When tool parameters exist, the cast produces an identical JSON object, no behavioral changes.