Skip to content

v8.0.0-rc.14-dev.34

v8.0.0-rc.14-dev.34: Close the lsp-hover project (#30615)
@StevenMcClankerton StevenMcClankerton tagged this 06 Oct 10:44 
Closes the lsp-hover project: rewrites the psl-parser README as an
overview and deletes `projects/lsp-hover/`.

## What changes

- **psl-parser README rewritten as an overview.** It used to list every
export and walk through binder internals, and several of those
statements were wrong after #30569 and #30591 (for example, that every
non-reference leaf "succeeds as a binding no-op"). It now describes what
the module is for:
  - the parse, symbol table, binder and interpretation pipeline;
  - the name lookup order;
- how diagnostics are divided between the binder and the specifications;
  - the entry points and package boundaries.

  It links the ADRs for detail.
- **`projects/lsp-hover/` is deleted.** No file outside it referenced
it.

No ADR changes. ADRs 231, 249, 254 and 255 were checked against the
binder changes, and none states the old matching rule.

## Project done-conditions

| Condition | Result |
|---|---|
| Each row of the hover table produces the listed content, verified by a
QA run | Met by driving the built language server over LSP against a
real postgres project (39 positions, all passing). **Not** checked by
hand inside VS Code, which is what the condition literally names. |
| Language-server tests cover hover for every resolution kind, including
a cross-file reference and a broken `///` run | Met (`hover.test.ts`,
psl-parser `doc-comment.test.ts`) |
| Binder tests cover `parameter`, `function`, `constant` and block
`attribute`, including `oneOf` | Met
(`binder-argument-resolutions.test.ts`, `block-binder.test.ts`) |
| `hoverProvider: true` advertised and asserted | Met (`server.test.ts`)
|
| Language-server README lists hover | Met |
| Final retro | Done |

Slices: #30569 and #30591, both merged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Reworked the parser package README into a concise overview of the
parsing pipeline, symbol-table construction, name resolution, and
family-specific interpretation.
* Clarified grammar selection, diagnostic responsibilities, package
boundaries, and where to find related documentation.
* The README no longer includes the former detailed API signatures, data
shapes, binding rules, parsing examples, and identity constraints.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Steven McClankerton <tatarintsev@prisma.io>
Co-authored-by: Steven McClankerton <tatarintsev@prisma.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Assets 2
Loading