Auth success page: offer the Prisma skills install command with one-click copy - #154
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughThe login success page now includes light and dark theme variables for the new skills section. It displays the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/auth/login.ts`:
- Around line 568-585: Add browser-level coverage for the command copy click
handler around button.addEventListener: verify successful clipboard writes,
clipboard failure selecting the command text, and removal of the copied state
after two seconds. Keep the existing dark-mode coverage and exercise the actual
UI interaction rather than testing implementation details in isolation.
- Around line 556-559: Update the copy-command button behavior and its
associated `.copied` state to expose an accessible announcement when copying
succeeds or falls back to selection. Keep the visual icon changes, but add a
live status or dynamically update the button’s accessible label so assistive
technology reports the current outcome instead of always announcing “Copy
command to clipboard.”
- Line 555: Update the fallback selection in the login flow around the command
rendering so it targets a dedicated command-only element rather than `.command
code`, excluding the `$ ` prompt from copied text. Ensure both copy paths select
the same command text.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 776c392b-9bd5-4d48-98ad-4d0586ebe787
📒 Files selected for processing (1)
packages/cli/src/auth/login.ts
No conflicts. Main's only new commit (#154) adds the skills install suggestion to the auth success page, touching packages/cli/src/auth/login.ts and packages/cli/tests/auth-login.test.ts; this branch touches neither. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
After
auth logincompletes, the browser success page now suggests installing the Prisma skills for AI coding agents (inspired by Stripe's equivalent screen): a short lead-in line and a code block withnpx skills add prisma/skills, plus a copy-to-clipboard button that flips to a checkmark on success and falls back to selecting the text if clipboard access is denied.