fix: export Get<Model>GroupByPayload type in prisma-client generator#29346
Merged
jacek-prisma merged 1 commit intoMar 17, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change adds the Changes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
jacek-prisma
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportkeyword to theGet<Model>GroupByPayloadtype inclient-generator-tsso it's accessible to users after generationFixes #29345
Problem
In the
prisma-clientgenerator (Prisma 7),Get<Model>GroupByPayloadis defined as a private type in each model file:In the old
prisma-client-jsgenerator, this type was accessible via thePrismanamespace (Prisma.GetMealInteractionGroupByPayload<{...}>). With the new per-model-file architecture, the missingexportmakes it completely unreachable.Fix
One-line change in
packages/client-generator-ts/src/TSClient/Model.ts:Test plan
prisma generatewithprisma-clientgeneratorGetMealInteractionGroupByPayloadis now exported from the generated model fileAwaited<GetMealInteractionGroupByPayload<{ by: [...], _count: {...} }>>resolves correctlySummary by CodeRabbit