Move smoke test to make target, reuse for CI#117
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Docker-based smoke test so it can be run consistently in CI and locally via a new make smoke-test target, and updates the GitHub Actions workflow to call that target instead of duplicating shell logic.
Changes:
- Added a
smoke-testMakefile target that builds the image, runs a container, and performs basic HTTP/content checks. - Simplified the CI workflow by replacing inline Docker/run/check steps with
make smoke-test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Makefile |
Adds smoke-test target and documents it in help; introduces default smoke-test configuration variables. |
.github/workflows/build-with-smoke-tests.yml |
Removes duplicated Docker/build/run/check steps and runs the new make smoke-test target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Otherwise if we had a production setting in the environment it would reuse it for the smoke test Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how smoke tests are run in CI and locally by moving the Docker-based smoke test logic into a reusable
smoke-testMakefile target. This change simplifies the GitHub Actions workflow and makes it easier to run smoke tests outside of CI.CI/CD workflow simplification:
.github/workflows/build-with-smoke-tests.ymlworkflow now usesmake smoke-testinstead of manually scripting Docker build/run/smoke-test steps, removing a large block of duplicated shell code.Makefile enhancements:
smoke-testtarget to theMakefile, encapsulating all Docker build, run, and smoke test steps. This target includes robust cleanup, version checks, port checks, admin GUI readiness checks, and content verification.DEFAULT_SMOKE_TEST_IMAGE,DEFAULT_SMOKE_TEST_CONTAINER, etc.) to make the smoke test easily configurable and portable.smoke-testtarget.Overall, this refactor improves maintainability, reduces duplication, and makes smoke testing more accessible for local development and CI.