fix(deps): raise the postcss floor to 8.5.18 (unblocks all CI) - #141
Merged
Conversation
The new PostCSS advisory (path traversal via sourceMappingURL auto-loading, disclosing arbitrary .map files; fixed in 8.5.18) fails `pnpm audit --prod`, which gates the `quality` job on every branch AND main's Docker publish — so main and all four open PRs went red at once without anyone changing code. The existing override was already `^8.5.12`, but a caret is not a floor that moves: the committed lockfile had resolved 8.5.17, which is vulnerable. Raising the override to `^8.5.18` and regenerating pulls 8.5.23. Same pattern, and same file, as the sharp and @babel/core entries — the header comment now records why the caret alone wasn't enough, since this will recur. Verified: `pnpm audit --prod` reports no known vulnerabilities, typecheck clean, 441 unit tests pass, and a full production build emits CSS correctly (postcss is the stylesheet pipeline, so the build is the real canary here, not the audit). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why CI went red everywhere
A new PostCSS advisory published — GHSA-r28c-9q8g-f849, path traversal via
sourceMappingURLauto-loading that discloses arbitrary.mapfiles, fixed in 8.5.18.pnpm audit --prodgates thequalityjob, so this single advisory turned main's Docker publish and all four open PRs red simultaneously, with nobody having changed any code:main(Build & Push Docker image to GHCR)qualityqualitypreview-imageThe fix
An override for postcss already existed at
^8.5.12— but a caret is not a floor that moves. The committed lockfile had resolved8.5.17, which is vulnerable. Raising the override to^8.5.18and regenerating resolves 8.5.23.This is the same mechanism, in the same file, as the existing
sharpand@babel/coreentries. The header comment now records why the caret alone wasn't sufficient, because this will recur the next time an 8.5.x advisory lands.Verification
pnpm audit --prod→ no known vulnerabilitiespnpm typecheckclean, 441 unit tests pass,pnpm lintcleanMerge order
Merging this first makes
maingreen again. #138 and #140 have the same commit cherry-picked onto them so they're green independently of merge order (identical patches drop out cleanly on rebase).🤖 Generated with Claude Code