Release v0.9.1 - #935
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe workspace package version in ChangesRelease version
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI surfaced a live advisory that belongs in this release rather than after it.
Updated to 0.44.2, where the cache entry is only created after verification succeeds. Deliberately folded into this PR rather than filed as follow-up: tagging v0.9.1 with a known signature-bypass in the dependency tree would put it in the released artifacts, and the whole point of the release gate is to stop exactly that. Verified locally:
One note on the bare The remaining |
Summary
Bumps the workspace version from 0.9.0 to 0.9.1 and refreshes
Cargo.lock, matching the shape of the v0.9.0 release commit (Cargo.toml2 lines,Cargo.lock22).Required before tagging:
release.ymlgates every build job onso a
v0.9.1tag on a tree that still says 0.9.0 failsbuild-deband skips thereleasejob entirely. That is the correct behavior and it is what caught this.Release contents
Six commits since v0.9.0. The two that matter:
mark_nonce_usedhad no callers anywhere in the workspace, so no entry was ever marked used, the reject branch was unreachable, and a repeated round-1 commitment fell through and was signed. Two signature shares over one nonce under different challenges gives = (z1 - z2) / (c1 - c2), the signer's key share. Commitments are now claimed where they are handed to the signing path, the store writes via temporary file plus fsync plus rename rather than leaving a claim in the page cache, and a versionless store is refused rather than silently trusted.Also #929 and #930 (request label carried through to the approval prompt, and marked when unverified), #934 (CI job token kept out of a PR-controlled tree), #931 (rate-limit test race).
Neither of the first two is known to have been exploited, and no evidence of exploitation was sought. Both are guards that were not doing what they were written to do.
Test plan
release.ymluses returns0.9.1against the newCargo.tomlcargo update --workspacerefreshes the five workspace members to 0.9.1 with no dependency changeskeep-coreentropy suite: 12 passed, includingmixing_hides_a_dead_os_sourcekeep-clinonce store suite: 8 passed, includinga_repeated_commitment_is_rejected,a_legacy_store_fails_closed,the_rejection_survives_a_reopenSummary by CodeRabbit