This repository was archived by the owner on Dec 27, 2023. It is now read-only.
Merged
Conversation
Member
vshivam
commented
Jul 28, 2013
vshivam
commented
- Added documentation
- Facebook Reading Capabilities.
ghost
assigned
src/ly/priv/mobile/Utilities.java
Outdated
Member
There was a problem hiding this comment.
Does this not display a warning about how a Closeable type has not been closed?
I looked at the implementation for FileChannel and it looks like all stream handles are closed when you invoke close() from a child channel object. In this case, the warning is annoying more than anything else, so go ahead and suppress the warning ( @SuppressWarnings("resource") ) and leave a comment as to why the warning was suppressed. The idea is to have clean, secure code and that starts with having no compile-time warnings.
Member
Author
There was a problem hiding this comment.
Modified. No more warnings for this case.
added 11 commits
September 16, 2013 22:12
Member
|
Good to go! |
born2c0de
added a commit
that referenced
this pull request
Sep 22, 2013
Integrated Facebook Reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.