[FBref] filter leagues in read_team_match_stats#290
Merged
probberechts merged 1 commit intomasterfrom Jul 10, 2023
Merged
Conversation
probberechts
added
bug
probberechts
force-pushed
the
fix-fbref-read_team_match_stats-filter-league
branch
from
93ef677 to
3507aa4
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 61.07% 60.96% -0.12%
==========================================
Files 10 10
Lines 1413 1409 -4
Branches 285 285
==========================================
- Hits 863 859 -4
Misses 504 504
Partials 46 46
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fbref.read_team_match_stats() method returned the match logs from all available competitions, ignore the leagues configured in the contstructor.