[FBref] Optimize reading team match history by creating and reading from csv cache#533
Closed
Kalaweksh wants to merge 3 commits intoprobberechts:masterfrom
Closed
[FBref] Optimize reading team match history by creating and reading from csv cache#533Kalaweksh wants to merge 3 commits intoprobberechts:masterfrom
Kalaweksh wants to merge 3 commits intoprobberechts:masterfrom
Conversation
-Modified read_team_match_stats to cache match history tables as csv files for faster reading. -Added force_cache parameter to read_team_match_stats for consistency with other methods.
-Moved read csv cache code into separate method to declutter read_team_match_stats. -All seasons that aren't the current season are dropped after reading from cache; we assume leagues and seasons in the cached df are complete.
Owner
|
Thank you for taking the time to submit this pull request. I really appreciate your effort for improving the project. Yet, I do not believe that this is a good solution. It is too ad hoc (I prefer a general solution for all FBref endpoints), will make things too complicated and does not really fit in the scope of soccerdata. I see that storing the full HTML page is inefficient, but I am not a huge fan of caching the preprocessed data. Soccerdata is meant to be able to download and parse the data. It is (at least for now) not intended as a database system. How to store the data and make it quickly accessible is out of scope. Rather, I see value in compacting the HTML page before caching it. For example by only keeping the tables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Changes
Modified read_team_match_stats to cache match history tables as csv files for faster reading.
Added force_cache parameter to read_team_match_stats for consistency with other methods.
Issues