Allow Visor to resolve its own comments via a command

[buger]

Visor should be able to resolve its own comments on a pull request if a user mentions it in a comment (e.g., '/visor resolve'), without requiring a new commit to be pushed.

[probelabs]

Thank you for the feature request! I understand you'd like Visor to be able to resolve its own comments on a pull request when a user mentions it with a command like /visor resolve, without requiring a new commit to be pushed.

What I Understand

• Current behavior: Visor comments remain on PRs until manually resolved or a new commit is pushed
• Desired behavior: A command (e.g., /visor resolve) that allows Visor to mark its own comments as resolved
• Use case: Users want to explicitly dismiss Visor's feedback without pushing a new commit

Questions for Clarification

To help me better understand the requirements:

1. Scope of resolution: Should /visor resolve resolve:

   • Only the specific comment that the command is posted in reply to?
   • All Visor comments on the PR?
   • Comments from specific checks only (e.g., /visor resolve security)?

2. Resolution semantics: What should "resolve" mean?

   • Mark the comment as "outdated" or "dismissed" with a visual indicator?
   • Edit the comment to add a "Resolved" badge/marker?
   • Minimize/collapse the comment content?

3. Permissions: Who should be able to trigger resolution?

   • Only the PR author?
   • Anyone with write access to the repository?
   • Anyone who can comment?

4. Reversibility: Should resolved comments be able to be un-resolved?

   • If so, with what command (e.g., /visor unresolve)?

5. Integration with existing behavior: How should this interact with:

   • New commits (which currently auto-resolve comments)?
   • The /status command?
   • Check re-runs via other commands?

Technical Context

Based on the codebase, I can see:

• Visor already has a command parsing system in src/commands.ts that handles /help and /status
• The CommentManager class handles comment creation and updates
• Comment metadata is tracked using HTML markers like <!-- visor-comment-id:... -->
• The GitHubFrontend manages comment updates and grouping

Potential Implementation Approach

A possible implementation could:

1. Add a new resolve command to the built-in commands in src/commands.ts
2. Handle the command in handleIssueComment (similar to how /status and /help are handled)
3. Update the target comment(s) to add a "resolved" marker or edit the content to indicate resolution
4. Store resolution state in comment metadata for tracking

Next Steps

Once you clarify the requirements above, I can provide more specific implementation guidance or help prioritize this feature for development.

References:

• visor/src/commands.ts:12-37 – Command parsing logic
• visor/src/commands.ts:39-68 – Help text generation
• visor/src/github-comments.ts:43-442 – Comment management
• visor/src/index.ts:926-1197 – Issue comment handling
• visor/docs/commands.md:230-287 – Command documentation

---

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>