Skip to content

fix: bug where unescaped double-quotes break installation #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

fix: bug where unescaped double-quotes break installation #78

wants to merge 8 commits into from

Conversation

@MaximDevoir
Copy link
Contributor

@MaximDevoir MaximDevoir commented Sep 10, 2019

Fixes #74

Note: This PR is built on top of patch/fix-gitignore PR.

@MaximDevoir
Describe node_modules entry
443fd94
@MaximDevoir
Add common log files
2261898
@MaximDevoir
Add lockfile from Yarn client
e1c975b 
A lockfile from NPM or Yarn should be commited.

Added `yarn.lock` to follow pattern of ignoring lockfiles.
@MaximDevoir
Describe tmp entry
d152fd7
@MaximDevoir
Rename .gitignore files from templates to gitignore
64eeb45
@MaximDevoir
Create .gitignore file
bcb0900 
- Skip adding the ignore entries if `gitignore` file is already present

- Append to `.gitignore` if already exists

This fixes #69, fixes #42
@MaximDevoir
Adhere to linter rules
5ce49b5
@MaximDevoir
Partially sanitize data by escaping double-quote characters
eb8aec7 
Fixes #74
@MaximDevoir MaximDevoir mentioned this pull request Sep 10, 2019
Closed
@MaximDevoir
Copy link
Contributor Author

MaximDevoir commented Sep 10, 2019 •
edited
Loading

Currently, this will only escape double-quotes. It is possible to set an option with jsesc to escape all JSON characters that JSON RFC states must be escaped. However, escaping all required characters raised more errors. There doesn't seem to be a need to handle those cases (if they even exist for this application).

@MaximDevoir MaximDevoir deleted the fix/issue-74 branch September 13, 2019 21:38
@MaximDevoir
Copy link
Contributor Author

MaximDevoir commented Sep 13, 2019 •
edited
Loading

Moved to #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonEtco JasonEtco Awaiting requested review from JasonEtco

@tcbyrd tcbyrd Awaiting requested review from tcbyrd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid package.json when including quotation marks in author's full name

1 participant

@MaximDevoir