Skip to content

Conversation

@MaximDevoir
Copy link
Contributor

Fixes #74

@MaximDevoir
Copy link
Contributor Author

Currently, this will only escape double-quotes. It is possible to set an option with jsesc to escape all JSON characters that JSON RFC states must be escaped. However, escaping all required characters raised more errors. There doesn't seem to be a need to handle those cases (if they even exist for this application).

@gr2m gr2m merged commit 6a9dd3c into probot:master Oct 30, 2019
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MaximDevoir MaximDevoir deleted the fix/issue-74 branch January 17, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid package.json when including quotation marks in author's full name

2 participants