replacement of es5 functions to es6 class def feat P5.AudioIn and audiocontext#508
Merged
endurance21 merged 6 commits intoprocessing:masterfrom Aug 9, 2020
Merged
Conversation
Collaborator
Author
|
@therewasaguy @kyle1james please review this pr! |
therewasaguy
reviewed
Aug 5, 2020
therewasaguy
reviewed
Aug 5, 2020
Member
therewasaguy
left a comment
therewasaguy
left a comment
There was a problem hiding this comment.
looks good, just one comment/question
Collaborator
Author
|
@therewasaguy @kyle1james ready to go ! ? |
therewasaguy
approved these changes
Aug 9, 2020
Member
therewasaguy
left a comment
therewasaguy
left a comment
There was a problem hiding this comment.
Looks good!
By the way, I've been told that, after starting a review, it's best not to force push. Force push makes it harder to see what changed exactly, which makes it harder to review. Fortunately GitHub shows it now https://github.com/processing/p5.js-sound/compare/4e6361409bc5c6b988d091716f0be1dd8ccbb219..8de0b757c4bcb851848f8d46de6e5077483a7d63 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
area covered