fix out-of-date values in console#4115
Open
joshuahhh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #1203: out-of-date values printed in console messages due to console-feed library's asynchronicity.
Demo:
Before on left, after on right. (You can ignore the HMR noise.)
Changes:
Instead of using console-feed's built-in Hook function, which uses setTimeout, I switch to a simpler hookConsoleSync which parses function arguments and calls the callback synchronously.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123