fix firefox scrollbar from fractional split pane size#4120
Merged
ksen0 merged 3 commits intoMay 21, 2026
Conversation
yugalkaushik
suggested changes
May 20, 2026
Contributor
yugalkaushik
left a comment
There was a problem hiding this comment.
@Nixxx19 I tested your PR locally and the scrollbars still exist. I checked on Brave and the issue is still present. On Chrome, there were no scrollbars before and there are still none.
Also, if you make any further changes, please share a preview as well.
Member
Author
|
hey @yugalkaushik thanks for testing and sorry for not attaching a screenshot earlier. just pushed a fix, tested locally in brave and the scrollbar is gone, screenshot attached. mind giving it another try?
|
Contributor
|
@Nixxx19 I tested it locally and everything looks clean now. When you get some time, could you please test it on Firefox as well so we can confirm the issue is fixed once and for all? I’ll approve the PR after you verify it there. |
Contributor
Member
|
Thanks both! |
ksen0
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



fixes #4046
the iframe was inheriting fractional pixel dimensions from its flex parent (eg 787.5px), so the sketch inside (which sees an integer 788) overflowed by 0.5px and triggered a scrollbar in firefox/brave.
floored the iframe width and height via a ResizeObserver on its parent and added
display: block. tested locally in brave, scrollbar is gone, chrome unchanged.