Why does p5js overwrite the global escape() function with different behavior?

[mhintz]

Hello!

Thanks for a great project! I think it's really cool to bring Processing to the browser.

I'm using p5js in a prototype project, and I've just found that it overwrites the global escape() function with a new function that provides slightly different behavior. The default global escape() converts the ASCII apostrophe:

'

into:

"%27"

whereas p5js escape() converts it to:

"'"

I'm not sure if there are other characters where encoding is affected in this way.
If this is a bug, I'm glad I caught it. If not a bug, could you document the reason for it?

Thanks much!
Mark

[lmccart]

@therewasaguy thoughts on this one? it looks like escape is being used as an internal helper, does it need to be attached to the p5.prototype? or if so, could it be _escape to differentiate it as an internal method?

[therewasaguy]

It is an internal helper and should not override global escape, sorry about
that. I can make the change to _escape on Friday.

On Wed, Dec 17, 2014 at 12:09 PM, Lauren McCarthy notifications@github.com
wrote:

@therewasaguy https://github.com/therewasaguy thoughts on this one? it
looks like escape is being used as an internal helper, does it need to be
attached to the p5.prototype? or if so, could it be _escape to
differentiate it as an internal method?

—
Reply to this email directly or view it on GitHub
https://github.com/lmccart/p5.js/issues/461#issuecomment-67356035.

[mhintz]

No problem! It didn't cause anything more than a few moments of serious head-scratching. Thanks for the awesome work!

[lmccart]

closed with https://github.com/lmccart/p5.js/pull/463