improved parameter validation - #2302
Conversation
# Conflicts: # src/core/error_helpers.js # src/webgl/p5.Matrix.js # src/webgl/p5.RendererGL.js
remove some of the debug code from minified build # Conflicts: # src/core/error_helpers.js
# Conflicts: # src/io/p5.Table.js
|
it looks like everything changed in error_helpers.js but that because I had to split apart the parameter validation (which is conditional on IS_MINIFIED) and the top-level warning stuff (which is not). also, jslint is fussy about the ordering of functions inside |
|
ok, this does the right thing with the argument count error. i fixed up some docs to accomodate. i also added the location of the error in the message, which you can click on to navigate in chrome's devtools . i'm not going to do any rebasing, because, for me at least, it always ends in tears. |
|
Ah, that's good that 2bb7aa removed the need for that extra parameter to |
|
travis? blacklisted? i have no idea what that is. |
|
It's the thing that's supposed to automatically run tests on PRs to check they run fine. (The tick/cross next to the PR in the PR list) Your PRs are marked as "abuse detected" here: https://travis-ci.org/processing/p5.js/requests Either way, I'm just confirming this passes tests and afaics is ready for merge! |
|
i'm sorry if I messed up the merge, it seems like i have a love/hate relationship with git: it just loves to hate me. |
|
this is great, sorry it took so long to merge |
this PR improves the parameter validation a little:
lookupParamDocresults. performance is significantly improved in debug.fixes #1329, #785