added X/Y sensitivity to orbitControl#2975
Merged
kjhollen merged 2 commits intoprocessing:webgl-gsoc-2018from Jun 12, 2018
Merged
added X/Y sensitivity to orbitControl#2975kjhollen merged 2 commits intoprocessing:webgl-gsoc-2018from
kjhollen merged 2 commits intoprocessing:webgl-gsoc-2018from
Conversation
14 tasks
Member
|
ugh it was the linter causing the build errors! glad you figured it out. I think this now supersedes #2956? It inverts the axis and adds the sensitivity params. |
Member
Author
Member
|
cool! okay, everything looks good here. merged into webgl-gsoc-2018 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2962.
Adds X and Y sensitivity parameters to
orbitControl(), allowing user to adjust how much rotation happens per mouse movement. This also allows user to invert axis of rotation by entering a negative value. This also changes default behavior to a non-inverted y-axis (pulling the mouse down makes the camera look down).I ended up using
width/2as the default scale factor for movement, to avoid having to hardcode this value. Sensitivity values passed in as arguments adjust based on this default scaling. TheangleMode(DEGREES)bug I mentioned here is not unique to orbitControl() and the issue is here: #2965.