add a line of documentation about the P2D renderer#3743
Merged
lmccart merged 2 commits intoprocessing:masterfrom May 20, 2019
Merged
add a line of documentation about the P2D renderer#3743lmccart merged 2 commits intoprocessing:masterfrom
lmccart merged 2 commits intoprocessing:masterfrom
Conversation
Contributor
Author
|
@maddyfisher does this seem ok to you? open to suggestions on better wording, etc! |
src/core/constants.js
Outdated
| module.exports = { | ||
| // GRAPHICS RENDERER | ||
| /** | ||
| * Denotes the default two-dimensional renderer. |
Member
There was a problem hiding this comment.
Wording wise "denote" may be a bit difficult for people whose English is not their first language.
Contributor
|
Looks great! I agree with the word changing for "denotes." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just adding a short description to the
P2Dconstant to maintain some parity with #3732