Skip to content

Make WebGL canvases clear alpha by default + add unit tests for this #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2019
Merged

Make WebGL canvases clear alpha by default + add unit tests for this #3835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2dd07
make webgl canvases clear alpha by default, add unit tests to ensure …
stalgiag Jun 24, 2019
32da107
update setAttributes docs
stalgiag Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/webgl/p5.RendererGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ p5.RendererGL.prototype = Object.create(p5.Renderer.prototype);

p5.RendererGL.prototype._setAttributeDefaults = function(pInst) {
var defaults = {
alpha: false,
alpha: true,
depth: true,
stencil: true,
antialias: false,
Expand Down Expand Up @@ -254,7 +254,7 @@ p5.RendererGL.prototype._resetContext = function(options, callback) {
* The available attributes are:
* <br>
* alpha - indicates if the canvas contains an alpha buffer
* default is false
* default is true
* <br><br>
* depth - indicates whether the drawing buffer has a depth buffer
* of at least 16 bits - default is true
Expand Down
74 changes: 72 additions & 2 deletions test/unit/webgl/p5.RendererGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,76 @@ suite('p5.RendererGL', function() {
});
});

suite('GL Renderer clear()', function() {
var pg;
var pixel;
test('webgl graphics background draws into webgl canvas', function(done) {
myp5.createCanvas(50, 50, myp5.WEBGL);
myp5.background(0, 255, 255, 255);
pg = myp5.createGraphics(25, 50, myp5.WEBGL);
pg.background(0);
myp5.image(pg, -myp5.width / 2, -myp5.height / 2);
pixel = myp5.get(0, 0);
assert.deepEqual(pixel, [0, 0, 0, 255]);
done();
});

test('transparent GL graphics with GL canvas', function(done) {
myp5.createCanvas(50, 50, myp5.WEBGL);
pg = myp5.createGraphics(25, 50, myp5.WEBGL);
myp5.background(0, 255, 255);
pg.clear();
myp5.image(pg, -myp5.width / 2, -myp5.height / 2);
pixel = myp5.get(0, 0);
assert.deepEqual(pixel, [0, 255, 255, 255]);
done();
});

test('semi-transparent GL graphics with GL canvas', function(done) {
myp5.createCanvas(50, 50, myp5.WEBGL);
pg = myp5.createGraphics(25, 50, myp5.WEBGL);
myp5.background(0, 255, 255);
pg.background(100, 100, 100, 100);
myp5.image(pg, -myp5.width / 2, -myp5.height / 2);
pixel = myp5.get(0, 0);
assert.deepEqual(pixel, [39, 194, 194, 194]);
done();
});

test('webgl graphics background draws into 2D canvas', function(done) {
myp5.createCanvas(50, 50);
myp5.background(0, 255, 255, 255);
pg = myp5.createGraphics(25, 50, myp5.WEBGL);
pg.background(0);
myp5.image(pg, 0, 0);
pixel = myp5.get(0, 0);
assert.deepEqual(pixel, [0, 0, 0, 255]);
done();
});

test('transparent GL graphics with 2D canvas', function(done) {
myp5.createCanvas(50, 50);
pg = myp5.createGraphics(25, 50, myp5.WEBGL);
myp5.background(0, 255, 255);
pg.clear();
myp5.image(pg, 0, 0);
pixel = myp5.get(0, 0);
assert.deepEqual(pixel, [0, 255, 255, 255]);
done();
});

test('semi-transparent GL graphics with 2D canvas', function(done) {
myp5.createCanvas(50, 50);
pg = myp5.createGraphics(25, 50, myp5.WEBGL);
myp5.background(0, 255, 255);
pg.background(100, 100, 100, 100);
myp5.image(pg, 0, 0);
pixel = myp5.get(0, 0);
assert.deepEqual(pixel, [39, 194, 194, 255]);
done();
});
});

suite('blendMode()', function() {
var testBlend = function(mode, intended) {
myp5.blendMode(mode);
Expand Down Expand Up @@ -274,8 +344,8 @@ suite('p5.RendererGL', function() {
test('blendModes change pixel colors as expected', function(done) {
myp5.createCanvas(10, 10, myp5.WEBGL);
myp5.noStroke();
assert.deepEqual([133, 69, 191, 255], mixAndReturn(myp5.ADD, 255));
assert.deepEqual([0, 0, 255, 255], mixAndReturn(myp5.REPLACE, 255));
assert.deepEqual([133, 69, 191, 158], mixAndReturn(myp5.ADD, 255));
assert.deepEqual([0, 0, 255, 122], mixAndReturn(myp5.REPLACE, 255));
assert.deepEqual([133, 255, 133, 255], mixAndReturn(myp5.SUBTRACT, 255));
assert.deepEqual([255, 0, 255, 255], mixAndReturn(myp5.SCREEN, 0));
assert.deepEqual([0, 255, 0, 255], mixAndReturn(myp5.EXCLUSION, 255));
Expand Down