Skip to content

Fix URLs to images to make them absolute#286

Closed
nosnilmot wants to merge 1 commit into
processone:developfrom
nosnilmot:fix-graph-urls
Closed

Fix URLs to images to make them absolute#286
nosnilmot wants to merge 1 commit into
processone:developfrom
nosnilmot:fix-graph-urls

Conversation

@nosnilmot
Copy link
Copy Markdown
Contributor

This fixes display of images on "Graphs" page of local web UI, and
eliminates these errors from inets_error.log :

[25/Jan/2018:17:51:39 -0000] access to /es/images/graphes-cpu-mean_tn.png failed for 1.2.3.4, reason:
"mod_esi: Client not authorized to evaluate: images/graphes-cpu-mean_tn.png"

This fixes display of images on "Graphs" page of local web UI, and
eliminates these errors from inets_error.log :

[25/Jan/2018:17:51:39 -0000] access to /es/images/graphes-cpu-mean_tn.png failed for 1.2.3.4, reason:
"mod_esi: Client not authorized to evaluate: images/graphes-cpu-mean_tn.png"
@highbass
Copy link
Copy Markdown

highbass commented Apr 18, 2018

this fix needs to be merged... it resolved issues with graphs not being displayed for me.

@nniclausse could you take a look please.

@tisba
Copy link
Copy Markdown
Collaborator

tisba commented Jun 1, 2018

I'm not sure how you are running into this issue. The tsung web UI does use graph_dy.thtml. I just gave this a try and I get the dygraph charts. Can you elaborate on how you've run into this issue?

Regarding your suggested changes: Making the image URLs absolute has the drawback, that you can no longer serve more then one report from a web server. If you have have multiple reports next to each other, then making the image paths absolute will have strange effects.

IMO for such reports it's a bad practise to assume that the report we are rending is the only webpage on this web server.

@nosnilmot
Copy link
Copy Markdown
Contributor Author

this problem is now masked by PR #291 which enables use of --dygraph always - when --dygraph is not used, the image references were broken

@tisba
Copy link
Copy Markdown
Collaborator

tisba commented Jun 1, 2018

Ah okay, I overlooked that. But I guess this issue can be closed then, right?

@nosnilmot nosnilmot closed this Jun 1, 2018
@nosnilmot nosnilmot deleted the fix-graph-urls branch January 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants