Skip to content

fix(collector): make release bundles host portable - #31

Merged
proerror77 merged 1 commit into
mainfrom
codex/fix-collector-release-install
Jul 15, 2026
Merged

fix(collector): make release bundles host portable#31
proerror77 merged 1 commit into
mainfrom
codex/fix-collector-release-install

Conversation

@proerror77

@proerror77 proerror77 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Fixes two failures observed during the Tokyo collector candidate install:\n\n- disable macOS AppleDouble/xattr sidecars in the deployment tar\n- make the shared release root traversable before the service-user self-test\n\nValidation:\n- bash -n\n- ShellCheck\n- deployment/aliyun/test-rust-lob-control-plane.sh\n- macOS tar contains no ._* entries\n- git diff --check\n\nNo production service was switched; the existing collector remains active.

Summary by CodeRabbit

  • Bug Fixes

    • Improved release packaging reliability by preventing unwanted metadata from being included in deployment bundles.
    • Ensured release directories are created with the correct permissions during installation, supporting more consistent deployments.
  • Tests

    • Added automated checks to verify deployment bundles and release directory setup behave as expected.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d2b783a-e30c-4b44-9bd0-be6f51a35ff8

📥 Commits

Reviewing files that changed from the base of the PR and between 43d3815 and d4a78e2.

📒 Files selected for processing (2)
  • deployment/aliyun/deploy-rust-lob-release.sh
  • deployment/aliyun/test-rust-lob-control-plane.sh

📝 Walkthrough

Walkthrough

The release deployment script disables tar copy-file behavior, creates /opt/monday/releases with mode 0755, and adds control-plane assertions for both changes.

Changes

Release deployment

Layer / File(s) Summary
Release packaging and installation validation
deployment/aliyun/deploy-rust-lob-release.sh, deployment/aliyun/test-rust-lob-control-plane.sh
The release bundle uses COPYFILE_DISABLE=1 during tar creation, the install script creates /opt/monday/releases with mode 0755, and tests assert both commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • proerror77/monday#29: Updates the same release deployment script and control-plane test assertions.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: improving collector release bundle portability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-collector-release-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 merged commit 6eb8e27 into main Jul 15, 2026
18 checks passed
@proerror77
proerror77 deleted the codex/fix-collector-release-install branch July 15, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant