fix(polymarket): allow Gate elapsed-time rounding - #526
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThe shadow-gate duration policy now accepts 900 and 901 seconds. Control-plane tests verify 901 seconds passes and 902 seconds remains rejected. ChangesShadow-gate duration validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Accept the fixed 900-second Gate when integer elapsed-time sampling reports 900 or 901 seconds; continue rejecting 899 and 902 seconds.
This is a small, already-specified bug fix, so a PRD is unnecessary.
Issue relationship
Refs #525
Out of scope
Dependency / merge order
None. Base is exact main
d51453d83472781119ed67e70716faaad2c7a5f0. Merge this PR before rebuilding the production release artifact and rerunning the real-segment preflight/Gate.Focused validation
gate policy rejected one second of elapsed-time rounding.bash deployment/aliyun/test-polymarket-raw-ops-control-plane.sh.bash -n deployment/aliyun/test-polymarket-raw-ops-control-plane.sh.git diff --check.Rollout / rollback impact
Rollout changes only the signed Gate policy and its focused contract test. A new exact-main artifact and real closed-segment preflight are required before a new Gate. The Gate remains fail-closed outside 900..901, and production remains Python until a fresh Gate, cutover, and 300-second smoke pass. Rollback is the existing automatic Python rollback.