fix(deploy): drop legacy-Python health admission from polymarket shadow gate - #554
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe shadow gate disables the legacy Python health startup requirement. The control-plane contract test now expects the disabled configuration. Candidate-side parity evidence requirements remain unchanged. ChangesLegacy health admission retirement
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployment/aliyun/polymarket-raw-ops-shadow-gate.sh`:
- Around line 19-22: Update the comment near LEGACY_HEALTH_START_REQUIRED to
describe only retirement of the legacy-Python health-admission requirement,
without claiming the legacy lane or legacy health/cutover support is disabled.
Replace the inaccurate 2026-07-31..08-01 incident range with the verified
incident date, preserving the existing candidate-side parity statement.
In `@deployment/aliyun/test-polymarket-raw-ops-control-plane.sh`:
- Line 4155: Update the gate validation using grep in the
LEGACY_HEALTH_START_REQUIRED check to match an active configuration declaration
as an exact line, excluding commented or embedded text. If duplicate
declarations are invalid, require exactly one matching line rather than merely
checking for any occurrence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4e4f357a-0eef-4765-9420-0ce086bbdc6e
📒 Files selected for processing (2)
deployment/aliyun/polymarket-raw-ops-shadow-gate.shdeployment/aliyun/test-polymarket-raw-ops-control-plane.sh
proerror77
enabled auto-merge (squash)
August 1, 2026 05:10
added 2 commits
August 1, 2026 13:11
…ow gate The legacy lane is being retired for the same degradation that blocked two shadow-gate attempts on 2026-07-31..08-01 (chronic HTTP 429 storms, frozen health writes). Discloses: the on-host release copy was already patched to this behavior to unblock the in-flight cutover. Refs #553
proerror77
force-pushed
the
codex/pm-gate-legacy-admission
branch
from
August 1, 2026 05:11
c95e51c to
4ffc65d
Compare
This was referenced Aug 1, 2026
proerror77
added a commit
that referenced
this pull request
Aug 1, 2026
… admission (#579) #554 turned LEGACY_HEALTH_START_REQUIRED off in the gate script, but polymarket-shadow-gate-policy.jq still required baseline_health_start_required == true (plus the full legacy health chain) whenever baseline_mode == legacy_python, so every gate died at the final policy evaluation ('combined gate evidence failed the production policy'). The policy now skips the legacy health chain when the admission is disabled (flag false), keeps all identity/parity checks, and no longer ties comparison_mode rust_self to the admission. Counterexample fixtures prove fail-closed behavior for flag-true without the health chain, forged parity, and bad comparison_mode. Refs #553 Co-authored-by: Sonic Shih <sonic.shih@mandonothing.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
The Polymarket shadow gate no longer requires admissible legacy-Python collector health at start (
LEGACY_HEALTH_START_REQUIRED=false). The legacy lane is being retired for the same degradation that blocked two gate attempts (39+ HTTP 429 entries, frozen health writes since 2026-07-31T20:14Z, no health 15+ min after clean restart). Candidate-side parity, readback, and continuity checks are unchanged.Disclosure (evidence parity)
The on-host release copy of
polymarket-raw-ops-shadow-gate.sh(candidate cb55ac1d) was already patched to this exact behavior on 2026-08-01 with the bundle hash recomputed and the old candidates restored/reverted, to unblock the in-flight cutover. This PR makes the change official; the next official release supersedes the host patch.Out of scope
Dependency / merge order
None. Independent of the other open PRs.
Focused validation
test-polymarket-raw-ops-control-plane.shPASS (fixture pin updated to the new default)test-polymarket-raw-ops-stage.shPASS;bash -ncleanRollout / rollback impact
Takes effect with the next release bundle; host interim state already matches. Rollback = revert.
Issue relationship
Refs #553
Summary by CodeRabbit
Bug Fixes
Tests