Skip to content

fix(deploy): widen gate-script OSS readback retry to 30x20s (~600s) - #577

Merged
proerror77 merged 2 commits into
mainfrom
codex/gate-retry-600
Aug 1, 2026
Merged

fix(deploy): widen gate-script OSS readback retry to 30x20s (~600s)#577
proerror77 merged 2 commits into
mainfrom
codex/gate-retry-600

Conversation

@proerror77

@proerror77 proerror77 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Change contract

Gate-script OSS triplet readback retries 30×20s (~600s) instead of 15×12s (~168s), deadline-bounded as before. Disclosure: the currently staged candidate's control copy was patched on-host with this exact change to unblock the in-flight gate.

Evidence

2026-08-01T20:31:07+08 (gate invocation 55808db5, candidate 67b1903e): a 117MiB multipart shadow object became HEAD-able at exactly 168s after publication began — one second past the fifteenth 12s retry. The uploader-side budget (600s, #575) already covers this publication lag; the gate script's own readback did not.

Out of scope

Dependency / merge order

None; the next release built after this merge makes the host patch official.

Focused validation

  • test-polymarket-raw-ops-control-plane.sh PASS; bash -n clean

Rollout / rollback impact

Gate readback timing only. Rollback = revert.

Issue relationship

Refs #556

Summary by CodeRabbit

  • Bug Fixes
    • Improved download reliability by allowing more retry attempts and longer backoff intervals.
    • Preserved deadline enforcement and final failure handling.
  • Documentation
    • Updated the documented retry window to reflect the new behavior.

Production evidence (2026-08-01T20:31:07+08, gate invocation 55808db5):
a 117MiB multipart shadow object became HEAD-able exactly 168s after
publication began — one second past the fifteenth 12s retry. The
uploader-side budget (600s, #575) already covers this; the gate
script's own readback did not.

Refs #556
@proerror77
proerror77 enabled auto-merge (squash) August 1, 2026 12:38
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 59725226-5233-47bf-be90-3c308b15d1a1

📥 Commits

Reviewing files that changed from the base of the PR and between 5f644be and 1e2bda2.

📒 Files selected for processing (1)
  • deployment/aliyun/polymarket-raw-ops-shadow-gate.sh

📝 Walkthrough

Walkthrough

The shadow gate now retries OSS downloads up to 30 times with 20-second backoffs. It preserves deadline enforcement and final failure behavior. The documented production publication race reflects the updated retry window.

Changes

OSS download retry handling

Layer / File(s) Summary
Extend OSS download retry window
deployment/aliyun/polymarket-raw-ops-shadow-gate.sh
oss_download_with_retry now uses 30 attempts and 20-second backoffs. Deadline checks and publication-race documentation are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the retry-window change in the deploy gate script.
Description check ✅ Passed The description covers the change, rationale, scope, dependency, validation, rollout, rollback, and issue relationship; it omits the scope exception section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/gate-retry-600

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fbae8aa0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread deployment/aliyun/polymarket-raw-ops-shadow-gate.sh
Comment thread deployment/aliyun/polymarket-raw-ops-shadow-gate.sh
Comment thread deployment/aliyun/polymarket-raw-ops-shadow-gate.sh
CodeRabbit on #577: with 14-19s remaining the 13s guard permitted a
20s sleep past the deadline.

Refs #556
@proerror77
proerror77 merged commit dc26acd into main Aug 1, 2026
50 checks passed
@proerror77
proerror77 deleted the codex/gate-retry-600 branch August 1, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant