ci: bind source-test image identity to profile - #724
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe ACR source-test publication flow now validates source-test profiles, generates profile-specific tags, propagates resolved identity values through the workflow, verifies image labels, and records profile-based publication evidence. ChangesSource-test identity publication
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WorkflowInput
participant SelectorScript
participant PublishSourceTest
participant SourceTestCommand
participant ACRRegistry
participant JobSummary
WorkflowInput->>SelectorScript: pass source SHA and source-test profile
SelectorScript->>SelectorScript: validate profile and generate source-test tag
SelectorScript->>PublishSourceTest: emit resolved profile and tag
PublishSourceTest->>SourceTestCommand: pass source SHA and profile
SourceTestCommand-->>PublishSourceTest: provide built source-test image
PublishSourceTest->>ACRRegistry: push image with profile-specific tag and labels
PublishSourceTest->>JobSummary: record publication identity and tag
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5391862 to
90d2819
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/acr-publish.yml:
- Line 694: The source-test image publication must prevent concurrent overwrites
after the existing manifest check. Update the publication flow using an enforced
registry immutability/locking mechanism or server-side create-only operation,
and ensure the recorded digest corresponds to the atomically created tag.
Document the enforced mechanism in deployment/aliyun/research/README.md for the
referenced source-test publication instructions; the workflow change belongs in
the source-test push path identified by IMAGE_TAG.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5019f6ad-b49d-4b55-b25d-935a7bef9dee
📒 Files selected for processing (5)
.github/scripts/select-acr-publish-source.sh.github/scripts/test-acr-publish-workflow.sh.github/scripts/test-research-image-release-artifact.sh.github/workflows/acr-publish.ymldeployment/aliyun/research/README.md
6202936 to
4aa07ff
Compare
Change contract
Bind each non-production research-source-test image to the exact trusted-main source SHA and one allowlisted offline profile. A stable source-test-SHA-profile tag is preflighted for absence, recorded with its profile and digest, and verified in the image labels before publication.
Issue relationship
None
Out of scope
No ACR publication, ACK Job, Secret, RBAC, nodepool, #689 resource, runtime deployment, credential, Testnet, Live, or real API change. Historical source-SHA-only tags are preserved and are not reused as profile evidence.
Dependencies and merge order
None. A later source-test receipt must dispatch from the final trusted-main SHA and use its profile-bound tag and digest.
Focused validation
Rollout and rollback
No runtime impact before merge. Roll back by reverting this commit; no registry tag is overwritten or relabeled.
Scope exception
None
Summary by CodeRabbit
New Features
Bug Fixes
Documentation