ci: make sccache optional in Rust validation - #77
Merged
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Keep
Rust WorkspaceandRust HFT Engine Fast Lanevalidating when the optional sccache action cannot reach GitHub REST APIs.What changed
mozilla-actions/sccache-actionand its wrapper/env wiring from the two affected CI jobs.Swatinem/rust-cacheand every existing Cargo validation command.Acceptance evidence
git diff --checkpassed.Out of scope
Dependency and merge order
Base:
main. Merge this PR before rerunning PR #67, so its Rust CI no longer depends on the failing optional action.Rollout and rollback
CI-only change. Revert this one commit to restore sccache; validation remains functionally equivalent but builds may run slower.