Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

chore(deps): bump github.com/mattn/go-runewidth from 0.0.9 to 0.0.10#561

Closed
dependabot[bot] wants to merge 1 commit intotrunkfrom
dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10
Closed

chore(deps): bump github.com/mattn/go-runewidth from 0.0.9 to 0.0.10#561
dependabot[bot] wants to merge 1 commit intotrunkfrom
dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jan 12, 2021 •
edited
Loading

Bumps github.com/mattn/go-runewidth from 0.0.9 to 0.0.10.

Commits
  • 59616a2 Merge pull request #29 from rivo/graphemestringwidth
  • f1f639b Reverted previous change to table. Also changed rainbow flag test. Today, the...
  • 49ce4bd Restored previously reverted changes (which were probably made by mistake).
  • d45afa6 Should use c.RuneWidth
  • 040263a Merge branch 'master' into graphemestringwidth
  • 98b1fa4 Adapted Truncate() function. Fixed table to make failing test case work.
  • b37dd43 Merge conflict resolved.
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added the deps Pull requests that update a dependency file or an issue related to a dependency label Jan 12, 2021
@zemzale zemzale mentioned this pull request Jan 12, 2021
Closed
@zemzale
Copy link
Copy Markdown
Collaborator

zemzale commented Jan 12, 2021

This breaks dependency to github.com/rivo/tview since it uses v0.0.9, but I opened an Issue about that already rivo/tview#548

After that I tried to use my local newest version of github.com/rivo/tview and there seems to be some breaking changes and we are not on the newest version.
I am gonna open a separate PR about updating 'github.com/rivo/tview'

@zemzale zemzale mentioned this pull request Jan 12, 2021
Merged
@zemzale zemzale closed this in #563 Jan 12, 2021
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Jan 12, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10 branch January 12, 2021 17:06
@zemzale
Copy link
Copy Markdown
Collaborator

zemzale commented Jan 12, 2021

@dependabot reopen

@dependabot dependabot Bot reopened this Jan 12, 2021
@dependabot dependabot Bot restored the dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10 branch January 12, 2021 17:09
@dependabot dependabot Bot force-pushed the dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10 branch from fcd0426 to b05cbe7 Compare January 12, 2021 17:11
@profclems profclems added the waiting Waiting on an external issue to be resolved label Jan 12, 2021
@profclems
Copy link
Copy Markdown
Owner

profclems commented Jan 12, 2021

I'm glad we've been able to swtich to v2 of rivo/tview with #563 without any issues.

We'll still have to put this PR on hold and wait for the issue @zemzale opened at rivo/tview#548 to be resolved.

@dependabot
chore(deps): bump github.com/mattn/go-runewidth from 0.0.9 to 0.0.10
6e45e9c 
Bumps [github.com/mattn/go-runewidth](https://github.com/mattn/go-runewidth) from 0.0.9 to 0.0.10.
- [Release notes](https://github.com/mattn/go-runewidth/releases)
- [Commits](mattn/go-runewidth@v0.0.9...v0.0.10)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10 branch from b05cbe7 to 6e45e9c Compare January 14, 2021 11:34
@zemzale zemzale mentioned this pull request Jan 18, 2021
Merged
@profclems
Copy link
Copy Markdown
Owner

profclems commented Jan 18, 2021

Closing this in favour of #578

@profclems profclems closed this Jan 18, 2021
@dependabot dependabot Bot deleted the dependabot/go_modules/github.com/mattn/go-runewidth-0.0.10 branch January 18, 2021 10:49
@profclems profclems removed the waiting Waiting on an external issue to be resolved label Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

deps Pull requests that update a dependency file or an issue related to a dependency size/XS status: blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zemzale @profclems