chore(deps): bump livekit protocol, server-sdk-go and pion/webrtc - #125
Merged
Conversation
Dependabot's go-modules bump (#123) fails to build: livekit/protocol 1.51.0 changed TransferSIPParticipant to return *TransferSIPParticipantResponse, but server-sdk-go v2.18.1 still returns *emptypb.Empty from its wrapper, so the module no longer compiles. No tagged server-sdk-go release carries the fix yet, so pin the SDK to a main pseudo-version (1da58cd, 2026-09-04) which was built against the new signature and requires go >= 1.26.3. - github.com/livekit/protocol v1.50.4 -> v1.51.1-0.20260903060125-0cf5ba018b8e - github.com/livekit/server-sdk-go/v2 v2.18.1 -> v2.18.2-0.20260904062056-1da58cd7b795 - github.com/pion/webrtc/v4 v4.2.18 -> v4.2.19 - go directive 1.26 -> 1.26.3 Supersedes #123. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y9ZqGBKouuFipzsRn6cUfa
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ThreatCrush Security Scan9 finding(s) HIGH/CRITICAL: 7 | LOW: 2
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #123, which cannot build.
Why #123 is red
livekit/protocol 1.51.0 changed
TransferSIPParticipantto return*TransferSIPParticipantResponseinstead of*emptypb.Empty. The pinnedserver-sdk-gov2.18.1 still wraps it with the old return type, sogo build ./...fails inside the SDK:Fix
No tagged
server-sdk-gorelease carries the fix yet (livekit/server-sdk-go#971 landed on main on 2026-08-21, latest tag is still v2.18.1). This pins the SDK to a main pseudo-version, which pulls the matching protocol pseudo-version and bumps thegodirective to 1.26.3 as the SDK requires.godirectiveLocally:
go build ./...,go vet ./...,go test ./...all pass.When livekit tags a release after 2.18.1, Dependabot will move the SDK back onto a tagged version on its own.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Y9ZqGBKouuFipzsRn6cUfa