0.21.1: a source's page reads its config field by field, never as one line of JSON - #89
Merged
Conversation
…ints a list as one line of JSON A source's config and cursor are jsonb, which the driver hands over as a string in production; the page printed JSON.stringify of that, so a bulk list of 167 addresses came out as one line of doubly-escaped JSON. The page now reads the config the way the adapter declared it: a value as a value, a list as a count with the entries folded under it (a hundred shown, the rest counted), an undeclared key as pretty JSON that wraps. The walk cursor is a sentence: how many pages read of how many, paused, done, or not started. The edit form takes a string config too and lists addresses one per line. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MwAoNvWzezmBHeT7oDHo3C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthony: "this is pretty bad visual bug", on the page a bulk submission lands on. The config was printed as
JSON.stringify(source.config), and the driver hands jsonb over as a string in production, so 167 addresses came out as one line of doubly-escaped JSON.lib/source-config.js:parseJson(string or object, junk is empty),describeConfig(adapter, config)(declared fields in the adapter's order; alistfield is a count with the first hundred entries and "and N more"; an undeclared key is pretty JSON),progressOf(cursor, {runCount, enabled})(the walk cursor as a sentence).<details>, JSON wraps. The edit form parses a string config too and shows list fields one address per line.Version 0.21.1.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MwAoNvWzezmBHeT7oDHo3C