Lay music out as music/artist/song.mp3 - #22
Merged
Conversation
The licence and attribution belong to the artist, not to each file, and a folder per artist is where a reader looks for that. Tracks are Þrøngva, original work by the project owner, now recorded in PROVENANCE.md. It also removes a real bug rather than just tidying. The download-budget guard excluded music with a `^music_` filename pattern, which silently under-counted the moment a track arrived under its own name — two did, and 22 MB of songs ended up inside a 6 MB guard. Music now sits in a subdirectory and the guard counts the flat .mp3 files in the audio root, so a track cannot be misfiled into the shell budget by a naming slip. The track table carries title and artist alongside the path, so a "now playing" line needs no second source of truth. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The licence and attribution belong to the artist, not to each file, and a folder per artist is where a reader looks for that. Tracks are Þrøngva, original work by the project owner, now recorded in
PROVENANCE.md.It also removes a real bug, not just tidies. The download-budget guard excluded music with a
^music_filename pattern, which silently under-counted the moment a track arrived under its own name — two did, and 22 MB of songs ended up inside a 6 MB guard. Music now sits in a subdirectory and the guard counts flat.mp3files in the audio root, so a track can't be misfiled into the shell budget by a naming slip.The track table carries title and artist alongside the path, so a "now playing" line needs no second source of truth.
201 tests pass. Shell total 6.20 MB, six tracks streamed separately.
🤖 Generated with Claude Code