Parse auth cookies without requiring spaces#139
Merged
ralyodio merged 1 commit intoJul 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an auth edge case in the crypto public-key routes.
The public-key endpoints parsed Cookie headers with
split("; "), which only works when every semicolon is followed by a space. Valid Cookie headers may be serialized asa=1;b=2by clients/proxies. In that case the Supabase auth cookie andsessioncookie could be merged into one parsed value, causing authenticated key fetch/sync requests to fail as unauthorized.This PR changes those parsers to split on
;with optional whitespace and adds a regression test for a Supabasebase64-...auth cookie followed immediately by another cookie without a space.Validation:
npx vitest run src/app/api/crypto/public-keys/route.test.jsnode --check src/app/api/crypto/public-keys/route.jsnode --check src/app/api/crypto/public-keys/all/route.jsnode --check src/app/api/crypto/public-keys/route.test.jsgit diff --check