Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/app/api/auth/verify-sms/route.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
return phoneRegex.test(phoneNumber);
}

/**
* @param {string | null} authHeader
* @returns {string | null}
*/
function getBearerToken(authHeader) {
if (typeof authHeader !== 'string') return null;

const match = authHeader.match(/^Bearer\s+(.+)$/i);
const token = match?.[1]?.trim();

return token || null;
}

/**
* POST /api/auth/verify-sms
* Verify SMS code and create/login user
Expand Down Expand Up @@ -59,7 +72,16 @@
});

// Validate input based on request type
if (useSession && authHeader) {
const token = getBearerToken(authHeader);
if (useSession) {
if (!token) {
logger.error('Missing session authorization header');
return NextResponse.json(
{ error: 'Missing or invalid authorization header', code: 'SESSION_AUTH_REQUIRED' },
{ status: 401 }
);
}

// Session-based request - username required
if (!phoneNumber || !username) {
logger.error( 'Missing required fields for session-based request', { phoneNumber: !!phoneNumber, username: !!username });
Expand Down Expand Up @@ -97,11 +119,9 @@
let verifyData;
let verifyError;

if (useSession && authHeader) {
if (useSession) {

Check failure

Code scanning / CodeQL

User-controlled bypass of security check High

This condition guards a sensitive
action
, but a
user-provided value
controls it.
logger.info('Processing session-based profile completion');

const token = authHeader.replace('Bearer ', '');


try {
// Validate the JWT token by getting user info
const { data: { user }, error: userError } = await supabase.auth.getUser(token);
Expand Down Expand Up @@ -462,4 +482,4 @@
{ status: 500 }
);
}
}
}
35 changes: 33 additions & 2 deletions src/app/api/auth/verify-sms/route.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ vi.mock('@supabase/supabase-js', () => ({
createClient: mocks.createClient
}));

function sessionRequest(body) {
function sessionRequest(body, authorization = 'Bearer test-session-token') {
return new Request('https://example.com/api/auth/verify-sms', {
method: 'POST',
headers: {
authorization: 'Bearer test-session-token',
authorization,
'content-type': 'application/json'
},
body: JSON.stringify(body)
Expand Down Expand Up @@ -59,6 +59,37 @@ describe('verify-sms session phone binding', () => {
expect(mocks.getUser).toHaveBeenCalledWith('test-session-token');
});

it('normalizes bearer scheme casing and extra spaces for session signup', async () => {
mocks.getUser.mockResolvedValue({
data: { user: { id: 'user-1', phone: '+15559999999' } },
error: null
});

const { POST } = await import('./route.js');
const res = await POST(sessionRequest({
useSession: true,
phoneNumber: '+15559999999',
username: 'alice'
}, 'bearer test-session-token '));

expect(mocks.getUser).toHaveBeenCalledWith('test-session-token');
expect(res.status).not.toBe(401);
});

it('rejects an empty session bearer header before session validation', async () => {
const { POST } = await import('./route.js');
const res = await POST(sessionRequest({
useSession: true,
phoneNumber: '+15559999999',
username: 'alice'
}, 'Bearer '));
const body = await res.json();

expect(res.status).toBe(401);
expect(body.code).toBe('SESSION_AUTH_REQUIRED');
expect(mocks.getUser).not.toHaveBeenCalled();
});

it('rejects anonymous / phoneless sessions', async () => {
mocks.getUser.mockResolvedValue({
data: { user: { id: 'anon', phone: null } },
Expand Down
Loading