Skip to content

Keep plugin-vscode dry-run builds side-effect free #156

@RasputinKaiser

Description

@RasputinKaiser

The plugin-vscode target currently verifies and packages through npx vsce during build, and falls back to a global npm install -g @vscode/vsce if the availability check fails.\n\nThat is surprising for validation/dry-run contexts because the shared harness sets dryRun: true specifically so adapters can avoid network/exec side effects. For this target, a dry-run build can still fetch a CLI or try a global install before users are ready to package.\n\nProposed fix:\n\n- when ctx.dryRun is set, write a deterministic package plan artifact instead of invoking vsce\n- keep real builds on the existing npx --yes vsce package path\n- add tests proving dry-run builds do not call exec and real builds still do\n\nThis keeps target validation safe while preserving the real packaging behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions