Skip to content

feat(plugin-vscode): short-circuit dry-run builds, emit vscode-package-plan.json#192

Open
hikaruhuimin wants to merge 2 commits into
profullstack:masterfrom
hikaruhuimin:dry-run/plugin-vscode
Open

feat(plugin-vscode): short-circuit dry-run builds, emit vscode-package-plan.json#192
hikaruhuimin wants to merge 2 commits into
profullstack:masterfrom
hikaruhuimin:dry-run/plugin-vscode

Conversation

@hikaruhuimin
Copy link
Copy Markdown
Contributor

Closes #156

/claim #156

Summary

  • short-circuit plugin-vscode dry-run builds before any vsce/npm exec checks
  • write a deterministic vscode-package-plan.json artifact with package dir, target, expected VSIX, and command
  • keep real builds on the existing npx --yes vsce package path
  • add tests proving dry-runs skip exec and real builds still invoke vsce packaging

Verification

  • pnpm exec vitest run packages/targets/plugin-vscode/src/index.test.ts
  • pnpm --filter @profullstack/sh1pt-target-plugin-vscode typecheck
  • pnpm --filter @profullstack/sh1pt typecheck
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep plugin-vscode dry-run builds side-effect free

1 participant