Skip to content

fix(coinpay): guard invalid webhook tolerance config - #876

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/coinpay-webhook-tolerance-guard
Jul 30, 2026
Merged

fix(coinpay): guard invalid webhook tolerance config#876
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/coinpay-webhook-tolerance-guard

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • Keep CoinPay webhook timestamp tolerance enforcement active when config receives invalid numeric values.
  • Preserve the explicit 0 escape hatch for disabling timestamp checks, while falling back to the default 300 seconds for NaN, negative, or otherwise invalid values.
  • Add a regression test showing stale but correctly signed CoinPay webhooks are rejected when config contains Number.NaN.

Validation

  • git diff --check

I attempted pnpm vitest run packages/payments/coinpay/src/index.test.ts and pnpm --filter @profullstack/sh1pt-payment-coinpay typecheck, but this checkout stops during dependency preparation because the committed lockfile fails the active supply-chain policy: @profullstack/autoblog@0.4.0 has no tarball integrity field. I did not modify the lockfile; the regression test is included for maintainers' normal CI/runtime.

Copilot AI review requested due to automatic review settings July 29, 2026 04:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

1 similar comment
@github-actions

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio
ralyodio merged commit c2a9f73 into profullstack:master Jul 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants