fix: add seedbox to TargetKind union - #882
Merged
Merged
Conversation
Eight seedbox adapters (bytesized, seedhosteu, ultracc, whatbox, gigarapid, dediseedbox, seedboxescc, rapidseedbox, pulsedmedia) declare kind: 'seedbox', but TargetKind did not include it, so their builds failed with TS2322. Add 'seedbox' to the union. Build was failing: pnpm -r build → bytesized Failed (TS2322)
Contributor
Author
|
Thanks for merging! This fix was submitted under the ugig.net bounty "I will pay for every bug fix found and PR submitted" (https://ugig.net/bounties — bounty c3137a9d-de39-4c1e-b48a-3df804c32bdf). Claim submission ID 8a22db62 (pending review). Payment: $1 SOL per fix PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
pnpm -r buildfails on@profullstack/sh1pt-seedbox-bytesizedwith TS2322: Type "seedbox" is not assignable to type 'TargetKind'.Nine seedbox adapters declare
kind: 'seedbox'butTargetKindinpackages/core/src/target.tsnever included 'seedbox', so none of them can build.Fix
Add 'seedbox' to the
TargetKindunion.Verification
pnpm --filter @profullstack/sh1pt-core build→ passespnpm -r build→ 681 packages done, 0 errors (all 8 seedbox adapters build)