fix(twitch): reject invalid IRC timestamps - #908
Merged
ralyodio merged 1 commit intoAug 1, 2026
Conversation
aiirvizionz
marked this pull request as ready for review
August 1, 2026 18:21
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
1 similar comment
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateRoot cause
Number.isFinite()does not guarantee that a numeric value can be represented as a valid JavaScriptDate. A finitetmi-sent-tsvalue outside the supported date range reachedtoISOString()and threw while processing an incoming Twitch message. Numeric formats that Twitch does not emit, such as exponent or fractional notation, were also accepted.Verification
9focused Vitest cases pass for valid, missing, malformed, unsafe, and out-of-range valuesgit diff --checkThe full workspace install/typecheck is currently blocked by the checked-in lockfile entry for
@profullstack/autoblog@0.4.0, whose tarball has no integrity metadata. GitHub CI remains the authoritative full-repository check.